Commit graph

1509 commits

Author SHA1 Message Date
Michael Catanzaro
401fad221d Fix style error 2015-07-23 13:01:29 -05:00
Michael Catanzaro
48202d6672 Assert that the ChessEngine has been stopped before it is destroyed
https://bugzilla.gnome.org/show_bug.cgi?id=724504
2015-07-23 12:59:07 -05:00
Sahil Sareen
6d4be6567f Reorder requires conditions on engine_stopped_cb
Check started first and then pid as engine being started
is the primary condition post which the pid should be enforced.
https://bugzilla.gnome.org/show_bug.cgi?id=724504
2015-07-23 23:22:17 +05:30
Michael Catanzaro
8ba6bcb992 Disconnect engine_stopped_cb when stopping the engine
What if, somehow, the cb gets called *after* ChessEngine.start()? Then
everything would break. Make sure that can't happen.

https://bugzilla.gnome.org/show_bug.cgi?id=724504
2015-07-23 23:18:33 +05:30
Michael Catanzaro
5a1786ac08 Fixup for the previous commit 2015-07-19 14:04:06 -05:00
Michael Catanzaro
20452ab1b9 Rename ChessEngine.stopped() to ChessEngine.stopped_unexpectedly()
Actually, this comment was not true prior to the previous commit:
ChessEngine.stopped() would always be called because
ChessEngine.engine_stopped_cb() would be called after
ChessEngine.stop(). But there really is no need to call it in that case,
so rename the signal. This is clearer anyway.
2015-07-19 14:01:01 -05:00
Michael Catanzaro
fe2a655aa9 Fix various mistakes in ChessEngine
fds can be 0 (hi stdin!). Various resource leaks due to not calling
stop() when the engine stops itself. Be careful to unset all values from
the previous engine in stop(), since they're now checked to ensure
they're not overwritten as a precondition of start(). Expect
engine_stopped_cb() to be called after stop().

https://bugzilla.gnome.org/show_bug.cgi?id=724504
2015-07-19 13:58:12 -05:00
Michael Catanzaro
cf425b02bd Add some preconditions to chess-engine.vala
Help avoid future mistakes here.

Also, avoid a case where we could call Source.remove(0) in the event of
an engine error.

https://bugzilla.gnome.org/show_bug.cgi?id=724504
2015-07-19 13:18:08 -05:00
Sahil Sareen
97263dd6cc Don't kill a broken chess-engine twice
https://bugzilla.gnome.org/show_bug.cgi?id=724504
2015-07-19 23:03:20 +05:30
Michael Catanzaro
71339098d7 Clarify a debug message 2015-07-19 10:42:00 -05:00
Yosef Or Boczko
b58860ef6c Updated Hebrew translation 2015-07-19 12:28:05 +03:00
Sahil Sareen
1763b65e9e Prepare 3.17.4 2015-07-18 19:36:29 +05:30
Balázs Úr
3b28d01f10 Updated Hungarian translation 2015-07-17 13:14:24 +00:00
Sahil Sareen
9329b590e4 Force engines to move after some timeout
Prevent a buggy engine from living forever without moving,
causing the game to appear to hang.
https://bugzilla.gnome.org/show_bug.cgi?id=726455
2015-07-16 00:26:43 +05:30
Pedro Albuquerque
ff3f644b97 Updated Portuguese translation 2015-07-15 09:08:17 +00:00
Daniel Mustieles
841f39b4cb Updated Spanish translation 2015-07-13 10:29:13 +02:00
Sahil Sareen
b3c5a872f9 Improve the dialog message for previous commit
Display a warning dialog if no chess engines are installed.
https://bugzilla.gnome.org/show_bug.cgi?id=732934
2015-07-11 16:58:04 +05:30
Sahil Sareen
826a8fd9d0 Display a warning dialog if no chess engines are installed
Warn players before starting the game if they don't have a chesss engine installed.
https://bugzilla.gnome.org/show_bug.cgi?id=732934
2015-07-11 00:17:28 +05:30
Pedro Albuquerque
b7f99ec89d Updated Portuguese translation 2015-07-01 22:03:57 +00:00
Gábor Kelemen
8be2ec29c9 Updated Hungarian translation 2015-06-29 22:41:15 +00:00
Gábor Kelemen
ee839e3009 Updated Hungarian translation 2015-06-29 20:13:32 +00:00
Michael Catanzaro
954adacb9e More build system cleanups 2015-06-28 11:06:38 -05:00
Michael Catanzaro
503ef090a5 Improve autogen.sh a bit more 2015-06-28 11:06:38 -05:00
Sahil Sareen
0665c5afae Prepare 3.17.3 2015-06-22 17:02:52 +05:30
Daniel Mustieles
387e9501cc Updated Spanish translation 2015-06-02 07:46:10 +00:00
Michael Catanzaro
e04bc15197 Tweak autogen.sh a bit more
* Spaces not tabs
* Don't print conditional tests
2015-06-01 07:24:10 -05:00
Dimitris Spingos
b5cac60d53 Updated Greek translation 2015-06-01 10:58:07 +03:00
Michael Catanzaro
6a70a2e1ec Further build system improvements 2015-05-30 08:25:48 -05:00
Michael Catanzaro
047a59ad02 Bring back the style checker
Didn't mean to remove this
2015-05-29 13:40:26 -05:00
Michael Catanzaro
87c5bdd85b Stop using gnome-common 2015-05-29 12:58:26 -05:00
Michael Catanzaro
69b49c53a0 Fix installation of hi-res icon 2015-05-29 12:52:55 -05:00
Daniel Mustieles
72766bce63 Updated Spanish translation 2015-05-29 08:32:03 +00:00
Daniel Mustieles
9bdadc026e Updated Spanish translation 2015-05-28 07:07:42 +00:00
Christian Kirbach
31ec4e0d2b Updated German translation 2015-05-25 21:00:20 +00:00
Sahil Sareen
4430e9e60f Prepare 3.17.2 2015-05-24 20:51:38 +05:30
Claude Paroz
99403f76d1 Updated French translation 2015-05-23 14:13:10 +02:00
Michael Catanzaro
77edcf7741 Remove our own copy of the style checker.
This now lives in libgames-support.

https://bugzilla.gnome.org/show_bug.cgi?id=749708
2015-05-22 14:25:30 +05:30
Kjartan Maraas
2700192e9b Updated Norwegian bokmål translation. 2015-05-14 16:27:12 +02:00
Marek Černocký
689824b5e5 Updated Czech translation 2015-05-07 12:28:29 +02:00
Sahil Sareen
23fc42f0cf Rename glChess to GNOMEChess in tests 2015-05-05 21:36:54 +05:30
Jordi Mas
074722167c Fixes to Catalan translation 2015-05-04 23:08:32 +02:00
Piotr Drąg
f38f9d1dd5 Updated POTFILES.in and POTFILES.skip 2015-05-03 19:50:39 +02:00
Sahil Sareen
16037c46f8 Fix bad pgn load behaviour - invalid moves in pgn
Don't load a pgn with invalid moves,
prompt a dialog to the player, and
start a new game.

https://bugzilla.gnome.org/show_bug.cgi?id=746218
2015-05-03 22:56:48 +05:30
Jakub Steiner
3b54bf4c72 icon: provice a symbolic variant of the app icon
since 3.16 used for the recolorable high contrast theme

https://bugzilla.gnome.org/show_bug.cgi?id=747025
2015-04-30 10:52:38 -05:00
Sahil Sareen
b3e1b5041c Prepare 3.17.1 2015-04-28 13:41:59 +05:30
Marek Černocký
5953148e6a Updated Czech translation 2015-04-25 12:23:10 +02:00
Marek Černocký
9a728fc2d2 Updated Czech translation 2015-04-24 22:15:18 +02:00
Sahil Sareen
0fbed8df94 Validate input when opening files
Add input validation for loading saved PGN games.

https://bugzilla.gnome.org/show_bug.cgi?id=704990
2015-04-21 19:47:57 +05:30
Johan Manuel
ba128dd084 Add option to alternate between black and white
Add the option 'Alternate' in 'Play as' in the preferences menu.
When selected, the player will play as the opposite color he played the
last time when starting a new game.

https://bugzilla.gnome.org/show_bug.cgi?id=747411
2015-04-15 10:58:27 +05:30
Trần Ngọc Quân
dd80c84af0 Updated Vietnamese translation
Signed-off-by: Trần Ngọc Quân <vnwildman@gmail.com>
2015-04-05 15:55:38 +07:00