procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

libgcc: Use initarray section type for .init_stack

Browse source 
One of my workmates found there is a warning like:

  libgcc/config/rs6000/morestack.S:402: Warning: ignoring
    incorrect section type for .init_array.00000

when compiling libgcc/config/rs6000/morestack.S.

Since commit r13-6545 touched that file recently, which was
suspected to be responsible for this warning, I did some
investigation and found this is a warning staying for a long
time.  For section .init_stack*, it's preferred to use
section type SHT_INIT_ARRAY.  So this patch is use
"@init_array" to replace "@progbits".

Although the warning is trivial, Segher suggested me to
post this to fix it, in order to avoid any possible
misunderstanding/confusion on the warning.

As Alan confirmed, this doesn't require a premise check
on if the existing binutils supports "@init_array" or not,
"because if you want split-stack to work, you must link
with gold, any version of binutils that has gold has an
assembler that understands @init_array". (Thanks Alan!)

libgcc/ChangeLog:

	* config/i386/morestack.S: Use @init_array rather than
	@progbits for section type of section .init_array.
	* config/rs6000/morestack.S: Likewise.
	* config/s390/morestack.S: Likewise.
This commit is contained in:
Kewen Lin 2023-06-04 22:39:32 -05:00
parent 29b7454553
commit 83c3550ee9
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libgcc/config/i386/morestack.S
View file

@ -850,7 +850,7 @@ __morestack_make_guard:
# This is ELF specific.
#if HAVE_INITFINI_ARRAY_SUPPORT
.section .init_array.00000,"aw",@progbits
.section .init_array.00000,"aw",@init_array
#else
.section .ctors.65535,"aw",@progbits
#endif

2
libgcc/config/rs6000/morestack.S
View file

@ -399,7 +399,7 @@ ENTRY0(__morestack_make_guard)
# Make __stack_split_initialize a high priority constructor.
#if HAVE_INITFINI_ARRAY_SUPPORT
.section .init_array.00000,"aw",@progbits
.section .init_array.00000,"aw",@init_array
#else
.section .ctors.65535,"aw",@progbits
#endif

2
libgcc/config/s390/morestack.S
View file

@ -597,7 +597,7 @@ __morestack_make_guard:
# Make __stack_split_initialize a high priority constructor.
#if HAVE_INITFINI_ARRAY_SUPPORT
.section .init_array.00000,"aw",@progbits
.section .init_array.00000,"aw",@init_array
#else
.section .ctors.65535,"aw",@progbits
#endif