procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

PR libstdc++/91067 fix missing exports for filesystem iterators

Browse source 
The copy assignment operator for recursive_directory_iterator was not
exported despite being needed. The __shared_ptr default constructors are
not needed when compiling with GCC but Clang requires them for -O1.

	PR libstdc++/91067
	* acinclude.m4 (libtool_VERSION): Bump to 6:27:0.
	* configure: Regenerate.
	* config/abi/pre/gnu.ver (GLIBCXX_3.4.27): Add new version. Export
	missing symbols.
	* testsuite/27_io/filesystem/iterators/91067.cc: New test.
	* testsuite/util/testsuite_abi.cc: Add new symbol version.

From-SVN: r273023
This commit is contained in:
Jonathan Wakely 2019-07-03 22:06:25 +01:00 • committed by Jonathan Wakely
parent 1bbffb87a9
commit 67699bf667
6 changed files with 75 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
libstdc++-v3/ChangeLog
View file

@ -1,3 +1,13 @@
2019-07-03 Jonathan Wakely <jwakely@redhat.com>
PR libstdc++/91067
* acinclude.m4 (libtool_VERSION): Bump to 6:27:0.
* configure: Regenerate.
* config/abi/pre/gnu.ver (GLIBCXX_3.4.27): Add new version. Export
missing symbols.
* testsuite/27_io/filesystem/iterators/91067.cc: New test.
* testsuite/util/testsuite_abi.cc: Add new symbol version.
2019-07-02 Jonathan Wakely <jwakely@redhat.com>
* include/bits/c++config (_GLIBCXX_HAVE_BUILTIN_LAUNDER)

2
libstdc++-v3/acinclude.m4
View file

@ -3832,7 +3832,7 @@ changequote([,])dnl
fi
# For libtool versioning info, format is CURRENT:REVISION:AGE
libtool_VERSION=6:26:0
libtool_VERSION=6:27:0
# Everything parsed; figure out what files and settings to use.
case $enable_symvers in

16
libstdc++-v3/config/abi/pre/gnu.ver
View file

@ -2266,6 +2266,22 @@ GLIBCXX_3.4.26 {
} GLIBCXX_3.4.25;
GLIBCXX_3.4.27 {
# __shared_ptr<_Dir>::__shared_ptr()
_ZNSt12__shared_ptrINSt10filesystem4_DirELN9__gnu_cxx12_Lock_policyE[012]EEC2Ev;
_ZNSt12__shared_ptrINSt10filesystem7__cxx114_DirELN9__gnu_cxx12_Lock_policyE[012]EEC2Ev;
# __shared_ptr<recursive_directory_iterator::_Dir_stack>::__shared_ptr()
_ZNSt12__shared_ptrINSt10filesystem28recursive_directory_iterator10_Dir_stackELN9__gnu_cxx12_Lock_policyE[012]EEC2Ev;
_ZNSt12__shared_ptrINSt10filesystem7__cxx1128recursive_directory_iterator10_Dir_stackELN9__gnu_cxx12_Lock_policyE[012]EEC2Ev;
# recursive_directory_iterator::operator=(const recursive_directory_iterator&)
_ZNSt10filesystem28recursive_directory_iteratoraSERKS0_;
_ZNSt10filesystem7__cxx1128recursive_directory_iteratoraSERKS1_;
} GLIBCXX_3.4.26;
# Symbols in the support library (libsupc++) have their own tag.
CXXABI_1.3 {

2
libstdc++-v3/configure vendored
View file

@ -79482,7 +79482,7 @@ $as_echo "$as_me: WARNING: === Symbol versioning will be disabled." >&2;}
fi
# For libtool versioning info, format is CURRENT:REVISION:AGE
libtool_VERSION=6:26:0
libtool_VERSION=6:27:0
# Everything parsed; figure out what files and settings to use.
case $enable_symvers in

45
libstdc++-v3/testsuite/27_io/filesystem/iterators/91067.cc Normal file
View file

@ -0,0 +1,45 @@
// Copyright (C) 2019 Free Software Foundation, Inc.
//
// This file is part of the GNU ISO C++ Library. This library is free
// software; you can redistribute it and/or modify it under the
// terms of the GNU General Public License as published by the
// Free Software Foundation; either version 3, or (at your option)
// any later version.
// This library is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
// You should have received a copy of the GNU General Public License along
// with this library; see the file COPYING3. If not see
// <http://www.gnu.org/licenses/>.
// { dg-options "-std=gnu++17" }
// { dg-do link { target c++17 } }
// { dg-require-filesystem-ts "" }
#include <filesystem>
void
test01()
{
std::filesystem::directory_iterator d;
d = d;
d = std::move(d);
}
void
test02()
{
std::filesystem::recursive_directory_iterator d;
d = d;
d = std::move(d);
}
int
main()
{
test01();
test02();
}

3
libstdc++-v3/testsuite/util/testsuite_abi.cc
View file

@ -207,6 +207,7 @@ check_version(symbol& test, bool added)
known_versions.push_back("GLIBCXX_3.4.24");
known_versions.push_back("GLIBCXX_3.4.25");
known_versions.push_back("GLIBCXX_3.4.26");
known_versions.push_back("GLIBCXX_3.4.27");
known_versions.push_back("CXXABI_1.3");
known_versions.push_back("CXXABI_LDBL_1.3");
known_versions.push_back("CXXABI_1.3.1");
@ -238,7 +239,7 @@ check_version(symbol& test, bool added)
test.version_status = symbol::incompatible;
// Check that added symbols are added in the latest pre-release version.
bool latestp = (test.version_name == "GLIBCXX_3.4.26"
bool latestp = (test.version_name == "GLIBCXX_3.4.27"
|| test.version_name == "CXXABI_1.3.12"
|| test.version_name == "CXXABI_FLOAT128"
|| test.version_name == "CXXABI_TM_1");