procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

re PR c++/89796 (Incorrect warning generated with OpenMP atomic capture)

Browse source 
PR c++/89796
	* semantics.c (finish_omp_atomic): Add warning_sentinel for
	-Wunused-value around finish_expr_stmt call.

	* g++.dg/gomp/pr89796.C: New test.
	* gcc.dg/gomp/pr89796.c: New test.

From-SVN: r269933
This commit is contained in:
Jakub Jelinek 2019-03-26 08:54:02 +01:00 • committed by Jakub Jelinek
parent 7a03cad76c
commit 22a32ea068
5 changed files with 93 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gcc/cp/ChangeLog
View file

@ -1,3 +1,9 @@
2019-03-26 Jakub Jelinek <jakub@redhat.com>
PR c++/89796
* semantics.c (finish_omp_atomic): Add warning_sentinel for
-Wunused-value around finish_expr_stmt call.
2019-03-25 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/84661

5
gcc/cp/semantics.c
View file

@ -8997,6 +8997,11 @@ finish_omp_atomic (location_t loc, enum tree_code code, enum tree_code opcode,
OMP_ATOMIC_MEMORY_ORDER (stmt) = mo;
SET_EXPR_LOCATION (stmt, loc);
}
/* Avoid -Wunused-value warnings here, the whole construct has side-effects
and even if it might be wrapped from fold-const.c or c-omp.c wrapped
in some tree that appears to be unused, the value is not unused. */
warning_sentinel w (warn_unused_value);
finish_expr_stmt (stmt);
}

6
gcc/testsuite/ChangeLog
View file

@ -1,3 +1,9 @@
2019-03-26 Jakub Jelinek <jakub@redhat.com>
PR c++/89796
* g++.dg/gomp/pr89796.C: New test.
* gcc.dg/gomp/pr89796.c: New test.
2019-03-25 David Malcolm <dmalcolm@redhat.com>
PR rtl-optimization/88347

53
gcc/testsuite/g++.dg/gomp/pr89796.C Normal file
View file

@ -0,0 +1,53 @@
// PR c++/89796
// { dg-do compile }
// { dg-additional-options "-Wunused-value" }
int
f1 (int &c)
{
int r;
#pragma omp atomic capture // { dg-bogus "value computed is not used" }
{ r = c; c++; }
return r;
}
template <int N>
int
f2 (int &c)
{
int r;
#pragma omp atomic capture // { dg-bogus "value computed is not used" }
{ r = c; c++; }
return r;
}
int
f3 (int &c)
{
return f2 <0> (c);
}
int
f4 (int *p)
{
int r;
#pragma omp atomic capture // { dg-bogus "value computed is not used" }
{ r = *p; (*p)++; }
return r;
}
template <int N>
int
f5 (int *p)
{
int r;
#pragma omp atomic capture // { dg-bogus "value computed is not used" }
{ r = *p; (*p)++; }
return r;
}
int
f6 (int *p)
{
return f5 <0> (p);
}

23
gcc/testsuite/gcc.dg/gomp/pr89796.c Normal file
View file

@ -0,0 +1,23 @@
/* PR c++/89796 */
/* { dg-do compile } */
/* { dg-additional-options "-Wunused-value" } */
int
f1 (int *p)
{
int r;
#pragma omp atomic capture /* { dg-bogus "value computed is not used" } */
{ r = *p; (*p)++; }
return r;
}
int
f2 (int *p)
{
int s
= ({ int r;
#pragma omp atomic capture /* { dg-bogus "value computed is not used" } */
{ r = *p; (*p)++; }
r; });
return s;
}