procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix completing-read functional REQUIRE-MATCH behavior

Browse source 
* lisp/minibuffer.el (completion--complete-and-exit): If
minibuffer-completion-confirm is a function which returns nil,
immediately fail to complete.

See bug#66187.
This commit is contained in:
Joseph Turner 2023-11-12 13:21:50 -08:00 • committed by Stefan Monnier
parent c22d0ae2dd
commit 77f5d4d523
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
lisp/minibuffer.el
View file

@ -1847,10 +1847,13 @@ appear to be a match."
;; Allow user to specify null string
((= beg end) (funcall exit-function))
;; The CONFIRM argument is a predicate.
((and (functionp minibuffer-completion-confirm)
(funcall minibuffer-completion-confirm
(buffer-substring beg end)))
(funcall exit-function))
((functionp minibuffer-completion-confirm)
(if (funcall minibuffer-completion-confirm
(buffer-substring beg end))
(funcall exit-function)
(unless completion-fail-discreetly
(ding)
(completion--message "No match"))))
;; See if we have a completion from the table.
((test-completion (buffer-substring beg end)
minibuffer-completion-table