We actually need to set a default for allow_claim_draw_dialog to account
for cases where games are loaded instead of started new.
game_needs_saving should already be covered everywhere, but it doesn't
hurt to set this. By default, games don't need saved, since nothing has
happened yet.
It doesn't actually have any translatable strings, so it's not strictly
necessary, but it should definitely be here as long as chess-scene.vala
is listed in POTFILES.in
The header bar size group was actually important: it was keeping the New
Game button at the proper height. And since it wasn't causing any
problems, let's just put it back.
https://bugzilla.gnome.org/show_bug.cgi?id=726951
Set the time labels to be a little bit wider than the widest they might
ever be, so they never resize.
This assumes that each player will be limited to at most 999 minutes,
which currently is not the case, but will be soon.
https://bugzilla.gnome.org/show_bug.cgi?id=726955
The horizontal size group is exacerbating the horrible resizing
behavior as the clock ticks down. It's not the size group's fault that
this is broken, but the size group makes it 1634435x worse.
The vertical size group is simply unnecessary in 3.12. In 3.10 it is
needed for the header bar buttons to have the same height, but forces
the buttons into odd (non-square) shapes. Let's just remove it.
https://bugzilla.gnome.org/show_bug.cgi?id=726951
The existing check for linux/prctl.h works great if you are compiling
the Vala code, but it's expected that users and distributions may start
with the distributed C files instead. If the tarball is generated on
Linux, then the call to prctl() will unconditionally appear in the
distributed C, and if the tarball isn't generated on Linux, then it will
be unconditionally absent.
There are only two ways to fix this: (a) not distribute any C code, or
(b) move the conditional compilation out of the Vala code. Though it
looks like the Autotools Vala world may be starting to lean towards (a),
let's be conservative and pick (b) for now.
https://bugzilla.gnome.org/show_bug.cgi?id=726614
