procyberian/nasm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove duplicate warnings for immediate overflow

Browse source 
For immediates, we had one overflow test in the bytecode interpreter
(in most cases via warn_overflow_opd()) and one in out(); this meant
we got two warnings instead of one every time.  Replace with only the
one in out().

Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
This commit is contained in:
H. Peter Anvin 2017-10-11 13:14:01 -07:00
parent aaefc7fe6b
commit 89215e9e37
1 changed files with 0 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
asm/assemble.c
View file

@ -302,14 +302,6 @@ static void warn_overflow_const(int64_t data, int size)
warn_overflow(size);
}
static void warn_overflow_opd(const struct operand *o, int size)
{
if (absolute_op(o)) {
if (overflow_general(o->offset, size))
warn_overflow(size);
}
}
static void warn_overflow_out(int64_t data, int size, enum out_sign sign)
{
bool err;
@ -1580,21 +1572,14 @@ static void gencode(struct out_data *data, insn *ins)
break;
case4(020):
if (opx->offset < -256 || opx->offset > 255)
nasm_error(ERR_WARNING | ERR_PASS2 | ERR_WARN_NOV,
"byte value exceeds bounds");
out_imm(data, opx, 1, OUT_WRAP);
break;
case4(024):
if (opx->offset < 0 || opx->offset > 255)
nasm_error(ERR_WARNING | ERR_PASS2 | ERR_WARN_NOV,
"unsigned byte value exceeds bounds");
out_imm(data, opx, 1, OUT_UNSIGNED);
break;
case4(030):
warn_overflow_opd(opx, 2);
out_imm(data, opx, 2, OUT_WRAP);
break;
@ -1603,18 +1588,15 @@ static void gencode(struct out_data *data, insn *ins)
size = (opx->type & BITS16) ? 2 : 4;
else
size = (bits == 16) ? 2 : 4;
warn_overflow_opd(opx, size);
out_imm(data, opx, size, OUT_WRAP);
break;
case4(040):
warn_overflow_opd(opx, 4);
out_imm(data, opx, 4, OUT_WRAP);
break;
case4(044):
size = ins->addr_size >> 3;
warn_overflow_opd(opx, size);
out_imm(data, opx, size, OUT_WRAP);
break;