mirror of
https://gitlab.gnome.org/GNOME/gimp.git
synced 2025-07-03 09:23:24 +00:00
9833ebd0ee
What this commit does is keep the same code logic while moving to GeglColor. Yet it's not **really** space-invaded yet. What we need to do now: 1. Take into account the image space, and this is what we must navigate through, in particular for various representations of RGB or HSV. I.e. that if the active image is in anyRGB, the RGB values shown must be within anyRGB. Right now, everything is still shown/used as sRGB (even though it's properly retrieved and transformed to the target space thanks to GeglColor). 2. Show space info to make things clear and explicit, by adding some label somewhere. 3. Allow to switch between image and softproof spaces, regarding out-of-gamut display. I.e. that while RGB/HSV must be shown within the image space (assuming it's anyRGB), we may want to show out-of-gamut area (pink areas) within the softproof space. This may mean adding a checkbox. Or maybe simply taking into account whether we are in softproof mode or not? 4. We can likely move off gimp_widget_get_color_transform() into using gimp_widget_get_render_space() for display drawing. We don't need any soft-proofing or black point compensation for any of these widgets so pure babl is fine. Indeed we want to show any in-gamut color correctly (and not transformed according to specific intents or through soft-proofing). We will take care of the proofing case with out-of-gamut area showing only. 5. In the various drawing functions, we should move to CAIRO_FORMAT_RGBA128F. The color selection area might be wide enough that it makes sense to be more accurate, especially as we are essentially showing color gradients in 1 or 2 directions in these various widgets. |
||
|---|---|---|
| .. | ||
| color-selector-cmyk.c | ||
| color-selector-water.c | ||
| color-selector-wheel.c | ||
| controller-dx-dinput.c | ||
| controller-linux-input.c | ||
| controller-midi.c | ||
| display-filter-aces-rrt.c | ||
| display-filter-clip-warning.c | ||
| display-filter-color-blind.c | ||
| display-filter-gamma.c | ||
| display-filter-high-contrast.c | ||
| gimpcolorwheel.c | ||
| gimpcolorwheel.h | ||
| gimpinputdevicestore-dx.c | ||
| gimpinputdevicestore-gudev.c | ||
| gimpinputdevicestore.h | ||
| meson.build | ||