procyberian/gimp
2
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/gimp.git synced 2025-07-04 01:43:24 +00:00
Code Issues 1 Projects 1 Releases Packages Wiki Activity Actions

plug-ins: Fix crash for bumpmaps without alpha channels

Browse source 
979a3c3c assumed that all bumpmaps in the Lighting Effects plug-in
would have an alpha channel, which is not always the case.
This patch adds a check via gimp_drawable_has_alpha (), and sets the
babl format accordingly.
This commit is contained in:
Alx Sa 2024-11-04 02:05:57 +00:00
parent fe6e1d77c8
commit c408d44e03
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
plug-ins/lighting/lighting-image.c
View file

@ -397,15 +397,19 @@ bumpmap_setup (GimpDrawable *bumpmap)
{
if (bumpmap)
{
gboolean has_alpha = gimp_drawable_has_alpha (bumpmap);
if (! bump_buffer)
{
bump_buffer = gimp_drawable_get_buffer (bumpmap);
}
if (gimp_drawable_is_rgb (bumpmap))
bump_format = babl_format ("R'aG'aB'aA u8");
bump_format = has_alpha ? babl_format ("R'aG'aB'aA u8") :
babl_format ("R'G'B' u8");
else
bump_format = babl_format ("Y'aA u8"); /* FIXME */
bump_format = has_alpha ? babl_format ("Y'aA u8") : /* FIXME */
babl_format ("Y' u8");
}
}