procyberian/gimp
2
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/gimp.git synced 2025-07-04 17:59:37 +00:00
Code Issues 1 Projects 1 Releases Packages Wiki Activity Actions

Bug 792744 - Gimp crashes attempting to merge down a hidden layer.

Browse source 
Don't use g_assert(). Instead use g_return_val_if_fail().
This commit therefore does not fix the actual bug, but at least it does
not crash. GIMP simply outputs a warning upon trying to merge down a
hidden layer. The actual fix will follow later.
This commit is contained in:
Jehan 2018-01-21 19:49:19 +01:00
parent 4d84925db0
commit b9577a783d
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
app/core/gimpimage-merge.c
View file

@ -449,7 +449,14 @@ gimp_image_merge_layers (GimpImage *image,
g_return_val_if_fail (GIMP_IS_IMAGE (image), NULL); g_return_val_if_fail (GIMP_IS_IMAGE (image), NULL);
g_return_val_if_fail (GIMP_IS_CONTEXT (context), NULL); g_return_val_if_fail (GIMP_IS_CONTEXT (context), NULL);
parent = gimp_layer_get_parent (merge_list->data); top_layer = merge_list->data;
parent = gimp_layer_get_parent (top_layer);
/* Build our graph inside the top-layer's parent node */
source_node = gimp_filter_get_node (GIMP_FILTER (top_layer));
node = gegl_node_get_parent (source_node);
g_return_val_if_fail (node, NULL);
/* Get the layer extents */ /* Get the layer extents */
x1 = y1 = 0; x1 = y1 = 0;
@ -519,7 +526,6 @@ gimp_image_merge_layers (GimpImage *image,
if ((x2 - x1) == 0 || (y2 - y1) == 0) if ((x2 - x1) == 0 || (y2 - y1) == 0)
return NULL; return NULL;
top_layer = merge_list->data;
bottom_layer = layer; bottom_layer = layer;
flatten_node = NULL; flatten_node = NULL;
@ -589,12 +595,6 @@ gimp_image_merge_layers (GimpImage *image,
*/ */
(void) gimp_projectable_get_graph (GIMP_PROJECTABLE (image)); (void) gimp_projectable_get_graph (GIMP_PROJECTABLE (image));
/* Build our graph inside the top-layer's parent node */
source_node = gimp_filter_get_node (GIMP_FILTER (top_layer));
node = gegl_node_get_parent (source_node);
g_assert (node != NULL);
offset_node = gegl_node_new_child (node, offset_node = gegl_node_new_child (node,
"operation", "gegl:translate", "operation", "gegl:translate",
"x", (gdouble) -x1, "x", (gdouble) -x1,