procyberian/gimp
2
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/gimp.git synced 2025-07-03 17:33:25 +00:00
Code Issues 1 Projects 1 Releases Packages Wiki Activity Actions

Issue #12569: clip issue with new filter API.

Browse source 
It was not a bug per-say. Simply the filters were set as having "clip"
set by default. We should add a libgimp function to let people choose
instead, but I want to think a bit better how we handle clip and masks
in filters before creating more API. Cf. #12874.

So for now, let's just set clip to FALSE. If we have to choose a single
possible clip value for filters made by the libgimp API, I believe this
is the nicer value.
This commit is contained in:
Jehan 2025-02-09 02:01:54 +01:00
parent 9a2709213d
commit ac0a722bf6
2 changed files with 14 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
app/pdb/drawable-filter-cmds.c
View file

@ -149,6 +149,13 @@ drawable_filter_new_invoker (GimpProcedure *procedure,
"operation", operation_name, "operation", operation_name,
NULL); NULL);
filter = gimp_drawable_filter_new (drawable, name, operation, NULL); filter = gimp_drawable_filter_new (drawable, name, operation, NULL);
/* We don't have a libgimp function for setting the clipping
* behavior. I want to look further into the whole logic first.
* In the meantime if all API-made filters must have a single
* clipping behavior, I believe that not-clipping (adjusting) is
* the nicer default.
*/
gimp_drawable_filter_set_clip (filter, FALSE);
g_clear_object (&operation); g_clear_object (&operation);
} }
} }

7
pdb/groups/drawable_filter.pdb
View file

@ -124,6 +124,13 @@ HELP
"operation", operation_name, "operation", operation_name,
NULL); NULL);
filter = gimp_drawable_filter_new (drawable, name, operation, NULL); filter = gimp_drawable_filter_new (drawable, name, operation, NULL);
/* We don't have a libgimp function for setting the clipping
* behavior. I want to look further into the whole logic first.
* In the meantime if all API-made filters must have a single
* clipping behavior, I believe that not-clipping (adjusting) is
* the nicer default.
*/
gimp_drawable_filter_set_clip (filter, FALSE);
g_clear_object (&operation); g_clear_object (&operation);
} }
} }