procyberian/gimp
2
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/gimp.git synced 2025-07-02 09:01:13 +00:00
Code Issues 1 Projects 1 Releases Packages Wiki Activity Actions

widgets: Prevent filter container duplication

Browse source 
Resolves #14206
If the user clicks the Fx icon in the DrawableTreeView
repeatedly (and quickly enough), the "closed" signal
function that cleans up the Filter popover does not
run before the next creation code is started. This can
results in the previous view being left in editor->vbox,
leading to duplication.
This patch checks if the editor and view already exist when
the popover opens, and if so, it runs the clean-up code first.
This commit is contained in:
Alx Sa 2025-06-08 01:42:24 +00:00
parent 9464e571ed
commit 6e58d05a56
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
app/widgets/gimpdrawabletreeview-filters.c
View file

@ -143,6 +143,10 @@ _gimp_drawable_tree_view_filter_editor_show (GimpDrawableTreeView *view,
gint n_editable;
gboolean visible = FALSE;
/* Prevents "duplicate" filter views if you click the popover too fast */
if (editor && editor->view)
_gimp_drawable_tree_view_filter_editor_hide (view);
if (! editor)
{
GtkWidget *vbox;
@ -229,7 +233,7 @@ _gimp_drawable_tree_view_filter_editor_show (GimpDrawableTreeView *view,
G_CALLBACK (gimp_drawable_filters_editor_edit_clicked),
view);
/* "raide" button */
/* "raise" button */
editor->raise_button =
gtk_button_new_from_icon_name (GIMP_ICON_GO_UP,
GTK_ICON_SIZE_SMALL_TOOLBAR);