From 61cef720f3cb056bf42e2d34b761ac3bf19cd7bb Mon Sep 17 00:00:00 2001 From: Jehan Date: Wed, 11 Dec 2024 14:19:28 +0100 Subject: [PATCH] Issue #7589: recommend Pango >= 1.55.0 to avoid ugly font breakage. This issue has eluded us for a long time and it was recently fixed in Pango (MR pango!745). We can't bump the minimum requirement because of our bookworm baseline for GIMP 3.0.0, but we can at least warn when building for macOS. --- meson.build | 30 +++++++++++++++++++++++++++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 5dcfd506ab..4e48f8c64c 100644 --- a/meson.build +++ b/meson.build @@ -450,9 +450,33 @@ endif conf.set_quoted('MYPAINT_BRUSHES_DIR', mypaint_brushes_dir) pango_minver = '1.50.0' -pango = dependency('pango', version: '>='+pango_minver) -pangocairo = dependency('pangocairo', version: '>='+pango_minver) -pangoft2 = dependency('pangoft2', version: '>='+pango_minver) +if platform_osx + pango_macos_recommended_version = '1.55.0' + pango_macos_warning=''' + GIMP encounters major display breakage on some macOS installations + with pango < 1.55.0. We highly recommend pango >= 1.55.0. + See: https://gitlab.gnome.org/GNOME/gimp/-/issues/7589 + ''' + pango = dependency('pango', + version: '>='+pango_macos_recommended_version, + required: false) + if pango.found() + pangocairo = dependency('pangocairo', version: '>='+pango_macos_recommended_version) + pangoft2 = dependency('pangoft2', version: '>='+pango_macos_recommended_version) + else + warning(pango_macos_warning) + warnings += pango_macos_warning + endif +else + pango = no_dep +endif + +if not pango.found() + pango = dependency('pango', version: '>='+pango_minver) + pangocairo = dependency('pangocairo', version: '>='+pango_minver) + pangoft2 = dependency('pangoft2', version: '>='+pango_minver) +endif + rsvg_minver = '2.40.6' rsvg = dependency('librsvg-2.0', version: '>='+rsvg_minver)