procyberian/gimp
2
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/gimp.git synced 2025-07-03 09:23:24 +00:00
Code Issues 1 Projects 1 Releases Packages Wiki Activity Actions

app: gimp_view_render_temp_buf_to_surface(): fix component extraction

Browse source 
The code was still assuming that GimpTempBuf is always 8 bit. Fixed
that, and optimized it to call babl_process() once per line instead of
per pixel. Fixes #13253.
This commit is contained in:
Michael Natterer 2025-06-01 02:57:00 +02:00
parent 7121109655
commit 6151deaff9
1 changed files with 12 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

25
app/widgets/gimpviewrenderer.c
View file

@ -1402,28 +1402,23 @@ gimp_view_render_temp_buf_to_surface (GimpViewRenderer *renderer,
dest += y * dest_stride + x * 4;
fish = babl_fish (temp_buf_format,
babl_format ("cairo-RGB24"));
babl_format ("R~G~B~ u8"));
for (i = y; i < (y + height); i++)
for (i = 0; i < height; i++)
{
const guchar *s = src;
guchar *d = dest;
guchar line[width * 3];
const guchar *s = line;
guint32 *d = (guint32*) dest;
gint j;
for (j = x; j < (x + width); j++, d += 4, s += bytes)
{
if (bytes > 2)
{
guchar pixel[4] = { s[channel], s[channel], s[channel], 255 };
babl_process (fish, src, line, width);
babl_process (fish, pixel, d, 1);
}
else
for (j = 0; j < width; j++)
{
guchar pixel[2] = { s[channel], 255 };
*d = s[channel] | s[channel] << 8 | s[channel] << 16;
babl_process (fish, pixel, d, 1);
}
s += 3;
d += 1;
}
src += rowstride;