procyberian/gimp
2
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/gimp.git synced 2025-07-04 17:59:37 +00:00
Code Issues 1 Projects 1 Releases Packages Wiki Activity Actions

Start using g_object_notify_by_pspec()

Browse source 
`g_object_notify()` actually takes a global lock to look up the property
by its name, which means there is a performance hit (albeit tiny) every
time this function is called. For this reason, always try to use
`g_object_notify_by_pspec()` instead.
This commit is contained in:
Niels De Graef 2019-08-03 08:23:10 +02:00 • committed by Michael Natterer
parent 910828bf51
commit 529aa743dd
1 changed files with 14 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

20
app/core/gimpobject.c
View file

@ -43,10 +43,10 @@ enum
enum enum
{ {
PROP_0, PROP_0,
PROP_NAME PROP_NAME,
N_PROPS
}; };
struct _GimpObjectPrivate struct _GimpObjectPrivate
{ {
gchar *name; gchar *name;
@ -78,6 +78,7 @@ G_DEFINE_TYPE_WITH_CODE (GimpObject, gimp_object, G_TYPE_OBJECT,
#define parent_class gimp_object_parent_class #define parent_class gimp_object_parent_class
static guint object_signals[LAST_SIGNAL] = { 0 }; static guint object_signals[LAST_SIGNAL] = { 0 };
static GParamSpec *object_props[N_PROPS] = { NULL, };
static void static void
@ -115,12 +116,13 @@ gimp_object_class_init (GimpObjectClass *klass)
klass->name_changed = NULL; klass->name_changed = NULL;
klass->get_memsize = gimp_object_real_get_memsize; klass->get_memsize = gimp_object_real_get_memsize;
g_object_class_install_property (object_class, PROP_NAME, object_props[PROP_NAME] = g_param_spec_string ("name",
g_param_spec_string ("name",
NULL, NULL, NULL, NULL,
NULL, NULL,
GIMP_PARAM_READWRITE | GIMP_PARAM_READWRITE |
G_PARAM_CONSTRUCT)); G_PARAM_CONSTRUCT);
g_object_class_install_properties (object_class, N_PROPS, object_props);
} }
static void static void
@ -229,7 +231,7 @@ gimp_object_set_name (GimpObject *object,
object->p->static_name = FALSE; object->p->static_name = FALSE;
gimp_object_name_changed (object); gimp_object_name_changed (object);
g_object_notify (G_OBJECT (object), "name"); g_object_notify_by_pspec (G_OBJECT (object), object_props[PROP_NAME]);
} }
/** /**
@ -256,7 +258,7 @@ gimp_object_set_name_safe (GimpObject *object,
object->p->static_name = FALSE; object->p->static_name = FALSE;
gimp_object_name_changed (object); gimp_object_name_changed (object);
g_object_notify (G_OBJECT (object), "name"); g_object_notify_by_pspec (G_OBJECT (object), object_props[PROP_NAME]);
} }
void void
@ -274,7 +276,7 @@ gimp_object_set_static_name (GimpObject *object,
object->p->static_name = TRUE; object->p->static_name = TRUE;
gimp_object_name_changed (object); gimp_object_name_changed (object);
g_object_notify (G_OBJECT (object), "name"); g_object_notify_by_pspec (G_OBJECT (object), object_props[PROP_NAME]);
} }
void void
@ -295,7 +297,7 @@ gimp_object_take_name (GimpObject *object,
object->p->static_name = FALSE; object->p->static_name = FALSE;
gimp_object_name_changed (object); gimp_object_name_changed (object);
g_object_notify (G_OBJECT (object), "name"); g_object_notify_by_pspec (G_OBJECT (object), object_props[PROP_NAME]);
} }
/** /**