procyberian/gimp
2
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/gimp.git synced 2025-07-04 01:43:24 +00:00
Code Issues 1 Projects 1 Releases Packages Wiki Activity Actions

Revert "libgimpbase: fix/improve docs/annotations."

Browse source 
This partly reverts commit d999248d70.

The GimpStringArray is still very weirdly handled, in particular
regarding the difference of processing with static_data set or not.
Still this g_return_val_if_fail() was making more problems. It may come
back but will need more coding to handle the side effects.
This commit is contained in:
Jehan 2019-08-05 23:15:07 +02:00
parent eacda4bb50
commit 17eb4c551f
1 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
libgimpbase/gimpparamspecs.c
View file

@ -1328,8 +1328,7 @@ gimp_value_take_float_array (GValue *value,
* *
* Creates a new #GimpArray containing string data, of size @length. * Creates a new #GimpArray containing string data, of size @length.
* *
* If @static_data is %TRUE, @data is used as-is and should also be * If @static_data is %TRUE, @data is used as-is.
* NULL-terminated.
* *
* If @static_data is %FALSE, the string and array will be re-allocated, * If @static_data is %FALSE, the string and array will be re-allocated,
* hence you are expected to free your input data after. * hence you are expected to free your input data after.
@ -1345,8 +1344,6 @@ gimp_string_array_new (const gchar **data,
g_return_val_if_fail ((data == NULL && length == 0) || g_return_val_if_fail ((data == NULL && length == 0) ||
(data != NULL && length > 0), NULL); (data != NULL && length > 0), NULL);
g_return_val_if_fail (! static_data || ! data ||
g_strv_length (data) == length, NULL);
array = g_slice_new0 (GimpArray); array = g_slice_new0 (GimpArray);
@ -1569,7 +1566,7 @@ gimp_value_get_string_array (const GValue *value)
* gimp_value_dup_string_array: * gimp_value_dup_string_array:
* @value: a #GValue holding a string #GimpArray. * @value: a #GValue holding a string #GimpArray.
* *
* Returns: (transfer full) (array zero-terminated=1): a deep copy of the array of strings. * Returns: (transfer full) (array zero-terminated=1): a deep copy of the array of strings.
*/ */
gchar ** gchar **
gimp_value_dup_string_array (const GValue *value) gimp_value_dup_string_array (const GValue *value)