From 0e7c4fec14c1ee832ebe2cb59a1751a59926983d Mon Sep 17 00:00:00 2001 From: Jehan Date: Sun, 23 Mar 2025 18:10:25 +0100 Subject: [PATCH] libgimpwidgets: slightly better form. Previous code was right and equivalent because gdk_wayland_window_export_handle() works asynchronously in the same thread (so phandle can't get overridden by mistake). Nevertheless a quick code scan felt surprising, so to avoid any such future surprise, let's just switch the order of statements. --- libgimpwidgets/gimpwidgetsutils.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libgimpwidgets/gimpwidgetsutils.c b/libgimpwidgets/gimpwidgetsutils.c index 00951c0c94..fb4f0b9cc2 100644 --- a/libgimpwidgets/gimpwidgetsutils.c +++ b/libgimpwidgets/gimpwidgetsutils.c @@ -1362,6 +1362,9 @@ gimp_widget_set_handle_on_mapped (GtkWidget *widget, handle = g_bytes_new (&id, sizeof (Window)); } #endif + + *phandle = handle; + #ifdef GDK_WINDOWING_WAYLAND if (GDK_IS_WAYLAND_WINDOW (surface)) { @@ -1379,7 +1382,5 @@ gimp_widget_set_handle_on_mapped (GtkWidget *widget, } #endif - *phandle = handle; - return FALSE; }