app, libgimp*, pdb, plug-ins: review and enhance MR !1549.
- Fix annotations for gimp_export_options_get_image() to make it
actually introspectable with the GimpImage being both input and
output. Even though the logic doesn't change much (the input image may
be overriden or not), it doesn't matter for introspection because
images are handled centrally by libgimp and therefore must not be
freed. Actually deleting the image from the central list of images
though remains a manual action depending on code logic, not some
automatic action to be handled by binding engines.
- Add G_GNUC_WARN_UNUSED_RESULT to gimp_export_options_get_image()
because ignoring the returned value is rarely a good idea (as you
usually want to delete the image).
- Remove gimp_export_options_new(): we don't need this constructor
because at this point, the best is to tell plug-in developers to just
pass NULL everywhere. This leaves us free to create a more useful
default constructor if needed, in the future. Main description for
GimpExportOptions has also been updated to say this.
- Add a data_destroy callback for the user data passed in
gimp_export_procedure_set_capabilities().
- Fixing annotations of 'export_options' object from pdb/pdb.pl: input
args would actually be (nullable) and would not transfer ownership
(calling code must still free the object). Return value's ownership on
the other hand is fully transfered.
- Add C and Python unit testing for GimpExportOptions and
gimp_export_options_get_image() in particular.
- Fix or improve various details.
Note that I have also considered for a long time changing the signature
of gimp_export_options_get_image() to return a boolean indicating
whether `image` had been replaced (hence needed deletion) or not. This
also meant getting rid of the GimpExportReturn enum. Right now it would
work because there are no third case, but I was considering the future
possibility that for instance we got some impossible conversion for some
future capability. I'm not sure it would ever happen; and for sure, this
is not desirable because it implies an export failure a bit late in the
workflow. But just in case, let's keep the enum return value. It does
not even make the using code that much more complicated (well just a
value comparison instead of a simple boolean test).
2024-08-17 15:06:27 +02:00
|
|
|
/* Sometimes odd dimensions may create weird situations. It's usually a
|
|
|
|
|
* good idea to test both even and odd dimensions.
|
|
|
|
|
*/
|
|
|
|
|
#define NEW_IMAGE_WIDTH 1920
|
|
|
|
|
#define NEW_IMAGE_HEIGHT 2001
|
|
|
|
|
|
|
|
|
|
static GimpValueArray *
|
|
|
|
|
gimp_c_test_run (GimpProcedure *procedure,
|
|
|
|
|
GimpRunMode run_mode,
|
|
|
|
|
GimpImage *image,
|
|
|
|
|
GimpDrawable **drawables,
|
|
|
|
|
GimpProcedureConfig *config,
|
|
|
|
|
gpointer run_data)
|
|
|
|
|
{
|
|
|
|
|
GimpImage **images;
|
|
|
|
|
GimpLayer **layers;
|
|
|
|
|
GeglBufferIterator *iter;
|
|
|
|
|
GeglBuffer *buffer1;
|
|
|
|
|
GeglBuffer *buffer2;
|
|
|
|
|
const Babl *format;
|
|
|
|
|
GimpImage *new_image;
|
|
|
|
|
GimpImage *original_image;
|
|
|
|
|
GimpTextLayer *text_layer;
|
|
|
|
|
GimpLayer *layer;
|
|
|
|
|
GimpLayer *export_layer;
|
|
|
|
|
GimpExportOptions *options;
|
|
|
|
|
GimpExportReturn delete;
|
|
|
|
|
gboolean identical_buffers;
|
|
|
|
|
|
|
|
|
|
new_image = gimp_image_new (NEW_IMAGE_WIDTH, NEW_IMAGE_HEIGHT, GIMP_RGB);
|
|
|
|
|
text_layer = gimp_text_layer_new (new_image, "hello world", gimp_context_get_font (),
|
|
|
|
|
20, gimp_unit_point ());
|
|
|
|
|
gimp_image_insert_layer (new_image, GIMP_LAYER (text_layer), NULL, 0);
|
|
|
|
|
text_layer = gimp_text_layer_new (new_image, "annyeong uju", gimp_context_get_font (),
|
|
|
|
|
20, gimp_unit_point ());
|
|
|
|
|
gimp_image_insert_layer (new_image, GIMP_LAYER (text_layer), NULL, 0);
|
|
|
|
|
|
|
|
|
|
options = g_object_new (GIMP_TYPE_EXPORT_OPTIONS,
|
|
|
|
|
"capabilities", GIMP_EXPORT_CAN_HANDLE_RGB | GIMP_EXPORT_CAN_HANDLE_ALPHA,
|
|
|
|
|
NULL);
|
|
|
|
|
|
|
|
|
|
GIMP_TEST_START("Verify start state (1)");
|
2024-10-22 13:10:06 +02:00
|
|
|
images = gimp_get_images ();
|
|
|
|
|
GIMP_TEST_END(gimp_core_object_array_get_length ((GObject **) images) == 1 && images[0] == new_image);
|
app, libgimp*, pdb, plug-ins: review and enhance MR !1549.
- Fix annotations for gimp_export_options_get_image() to make it
actually introspectable with the GimpImage being both input and
output. Even though the logic doesn't change much (the input image may
be overriden or not), it doesn't matter for introspection because
images are handled centrally by libgimp and therefore must not be
freed. Actually deleting the image from the central list of images
though remains a manual action depending on code logic, not some
automatic action to be handled by binding engines.
- Add G_GNUC_WARN_UNUSED_RESULT to gimp_export_options_get_image()
because ignoring the returned value is rarely a good idea (as you
usually want to delete the image).
- Remove gimp_export_options_new(): we don't need this constructor
because at this point, the best is to tell plug-in developers to just
pass NULL everywhere. This leaves us free to create a more useful
default constructor if needed, in the future. Main description for
GimpExportOptions has also been updated to say this.
- Add a data_destroy callback for the user data passed in
gimp_export_procedure_set_capabilities().
- Fixing annotations of 'export_options' object from pdb/pdb.pl: input
args would actually be (nullable) and would not transfer ownership
(calling code must still free the object). Return value's ownership on
the other hand is fully transfered.
- Add C and Python unit testing for GimpExportOptions and
gimp_export_options_get_image() in particular.
- Fix or improve various details.
Note that I have also considered for a long time changing the signature
of gimp_export_options_get_image() to return a boolean indicating
whether `image` had been replaced (hence needed deletion) or not. This
also meant getting rid of the GimpExportReturn enum. Right now it would
work because there are no third case, but I was considering the future
possibility that for instance we got some impossible conversion for some
future capability. I'm not sure it would ever happen; and for sure, this
is not desirable because it implies an export failure a bit late in the
workflow. But just in case, let's keep the enum return value. It does
not even make the using code that much more complicated (well just a
value comparison instead of a simple boolean test).
2024-08-17 15:06:27 +02:00
|
|
|
g_free (images);
|
|
|
|
|
|
|
|
|
|
GIMP_TEST_START("Verify start state (2)");
|
2024-10-22 01:47:45 +02:00
|
|
|
layers = gimp_image_get_layers (new_image);
|
|
|
|
|
GIMP_TEST_END(gimp_core_object_array_get_length ((GObject **) layers) == 2);
|
app, libgimp*, pdb, plug-ins: review and enhance MR !1549.
- Fix annotations for gimp_export_options_get_image() to make it
actually introspectable with the GimpImage being both input and
output. Even though the logic doesn't change much (the input image may
be overriden or not), it doesn't matter for introspection because
images are handled centrally by libgimp and therefore must not be
freed. Actually deleting the image from the central list of images
though remains a manual action depending on code logic, not some
automatic action to be handled by binding engines.
- Add G_GNUC_WARN_UNUSED_RESULT to gimp_export_options_get_image()
because ignoring the returned value is rarely a good idea (as you
usually want to delete the image).
- Remove gimp_export_options_new(): we don't need this constructor
because at this point, the best is to tell plug-in developers to just
pass NULL everywhere. This leaves us free to create a more useful
default constructor if needed, in the future. Main description for
GimpExportOptions has also been updated to say this.
- Add a data_destroy callback for the user data passed in
gimp_export_procedure_set_capabilities().
- Fixing annotations of 'export_options' object from pdb/pdb.pl: input
args would actually be (nullable) and would not transfer ownership
(calling code must still free the object). Return value's ownership on
the other hand is fully transfered.
- Add C and Python unit testing for GimpExportOptions and
gimp_export_options_get_image() in particular.
- Fix or improve various details.
Note that I have also considered for a long time changing the signature
of gimp_export_options_get_image() to return a boolean indicating
whether `image` had been replaced (hence needed deletion) or not. This
also meant getting rid of the GimpExportReturn enum. Right now it would
work because there are no third case, but I was considering the future
possibility that for instance we got some impossible conversion for some
future capability. I'm not sure it would ever happen; and for sure, this
is not desirable because it implies an export failure a bit late in the
workflow. But just in case, let's keep the enum return value. It does
not even make the using code that much more complicated (well just a
value comparison instead of a simple boolean test).
2024-08-17 15:06:27 +02:00
|
|
|
g_free (layers);
|
|
|
|
|
|
|
|
|
|
original_image = new_image;
|
|
|
|
|
|
|
|
|
|
GIMP_TEST_START("gimp_export_options_get_image() created a new image");
|
|
|
|
|
delete = gimp_export_options_get_image (options, &new_image);
|
2024-10-22 13:10:06 +02:00
|
|
|
images = gimp_get_images ();
|
|
|
|
|
GIMP_TEST_END(delete == GIMP_EXPORT_EXPORT && gimp_core_object_array_get_length ((GObject **) images) == 2 && new_image != original_image);
|
app, libgimp*, pdb, plug-ins: review and enhance MR !1549.
- Fix annotations for gimp_export_options_get_image() to make it
actually introspectable with the GimpImage being both input and
output. Even though the logic doesn't change much (the input image may
be overriden or not), it doesn't matter for introspection because
images are handled centrally by libgimp and therefore must not be
freed. Actually deleting the image from the central list of images
though remains a manual action depending on code logic, not some
automatic action to be handled by binding engines.
- Add G_GNUC_WARN_UNUSED_RESULT to gimp_export_options_get_image()
because ignoring the returned value is rarely a good idea (as you
usually want to delete the image).
- Remove gimp_export_options_new(): we don't need this constructor
because at this point, the best is to tell plug-in developers to just
pass NULL everywhere. This leaves us free to create a more useful
default constructor if needed, in the future. Main description for
GimpExportOptions has also been updated to say this.
- Add a data_destroy callback for the user data passed in
gimp_export_procedure_set_capabilities().
- Fixing annotations of 'export_options' object from pdb/pdb.pl: input
args would actually be (nullable) and would not transfer ownership
(calling code must still free the object). Return value's ownership on
the other hand is fully transfered.
- Add C and Python unit testing for GimpExportOptions and
gimp_export_options_get_image() in particular.
- Fix or improve various details.
Note that I have also considered for a long time changing the signature
of gimp_export_options_get_image() to return a boolean indicating
whether `image` had been replaced (hence needed deletion) or not. This
also meant getting rid of the GimpExportReturn enum. Right now it would
work because there are no third case, but I was considering the future
possibility that for instance we got some impossible conversion for some
future capability. I'm not sure it would ever happen; and for sure, this
is not desirable because it implies an export failure a bit late in the
workflow. But just in case, let's keep the enum return value. It does
not even make the using code that much more complicated (well just a
value comparison instead of a simple boolean test).
2024-08-17 15:06:27 +02:00
|
|
|
g_free (images);
|
|
|
|
|
|
|
|
|
|
GIMP_TEST_START("The new image has a single layer");
|
2024-10-22 01:47:45 +02:00
|
|
|
layers = gimp_image_get_layers (new_image);
|
|
|
|
|
GIMP_TEST_END(gimp_core_object_array_get_length ((GObject **) layers) == 1);
|
app, libgimp*, pdb, plug-ins: review and enhance MR !1549.
- Fix annotations for gimp_export_options_get_image() to make it
actually introspectable with the GimpImage being both input and
output. Even though the logic doesn't change much (the input image may
be overriden or not), it doesn't matter for introspection because
images are handled centrally by libgimp and therefore must not be
freed. Actually deleting the image from the central list of images
though remains a manual action depending on code logic, not some
automatic action to be handled by binding engines.
- Add G_GNUC_WARN_UNUSED_RESULT to gimp_export_options_get_image()
because ignoring the returned value is rarely a good idea (as you
usually want to delete the image).
- Remove gimp_export_options_new(): we don't need this constructor
because at this point, the best is to tell plug-in developers to just
pass NULL everywhere. This leaves us free to create a more useful
default constructor if needed, in the future. Main description for
GimpExportOptions has also been updated to say this.
- Add a data_destroy callback for the user data passed in
gimp_export_procedure_set_capabilities().
- Fixing annotations of 'export_options' object from pdb/pdb.pl: input
args would actually be (nullable) and would not transfer ownership
(calling code must still free the object). Return value's ownership on
the other hand is fully transfered.
- Add C and Python unit testing for GimpExportOptions and
gimp_export_options_get_image() in particular.
- Fix or improve various details.
Note that I have also considered for a long time changing the signature
of gimp_export_options_get_image() to return a boolean indicating
whether `image` had been replaced (hence needed deletion) or not. This
also meant getting rid of the GimpExportReturn enum. Right now it would
work because there are no third case, but I was considering the future
possibility that for instance we got some impossible conversion for some
future capability. I'm not sure it would ever happen; and for sure, this
is not desirable because it implies an export failure a bit late in the
workflow. But just in case, let's keep the enum return value. It does
not even make the using code that much more complicated (well just a
value comparison instead of a simple boolean test).
2024-08-17 15:06:27 +02:00
|
|
|
|
|
|
|
|
export_layer = layers[0];
|
|
|
|
|
g_free (layers);
|
|
|
|
|
|
|
|
|
|
layer = gimp_image_merge_visible_layers (original_image, GIMP_CLIP_TO_IMAGE);
|
|
|
|
|
|
|
|
|
|
GIMP_TEST_START("Compare export buffer with original image's merged buffer");
|
|
|
|
|
buffer1 = gimp_drawable_get_buffer (GIMP_DRAWABLE (layer));
|
|
|
|
|
buffer2 = gimp_drawable_get_buffer (GIMP_DRAWABLE (export_layer));
|
|
|
|
|
format = gegl_buffer_get_format (buffer1);
|
|
|
|
|
iter = gegl_buffer_iterator_new (buffer1, NULL, 0, format,
|
|
|
|
|
GEGL_ACCESS_READ, GEGL_ABYSS_NONE, 2);
|
|
|
|
|
gegl_buffer_iterator_add (iter, buffer2, NULL, 0, format,
|
|
|
|
|
GEGL_ACCESS_READ, GEGL_ABYSS_NONE);
|
|
|
|
|
|
|
|
|
|
identical_buffers = TRUE;
|
|
|
|
|
while (gegl_buffer_iterator_next (iter))
|
|
|
|
|
{
|
|
|
|
|
const gfloat *src1 = (const gfloat *) iter->items[0].data;
|
|
|
|
|
const gfloat *src2 = (const gfloat *) iter->items[1].data;
|
|
|
|
|
gint count = iter->length;
|
|
|
|
|
|
|
|
|
|
if (memcmp (src1, src2, count * babl_format_get_bytes_per_pixel (format)) != 0)
|
|
|
|
|
{
|
|
|
|
|
identical_buffers = FALSE;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
GIMP_TEST_END(identical_buffers == TRUE);
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
GIMP_TEST_RETURN
|
|
|
|
|
}
|