procyberian/gimp
2
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/gimp.git synced 2025-07-04 01:43:24 +00:00
Code Issues 1 Projects 1 Releases Packages Wiki Activity Actions
gimp/app/widgets/gimpaction-history.c

510 lines
14 KiB
C
Raw Normal View History

Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
/* GIMP - The GNU Image Manipulation Program
app: more action search cleanup - standard copyright headers - use gtk_action_is_sensitive() not get_sensitive() - formatting
2014-02-18 23:24:48 +01:00
* Copyright (C) 1995 Spencer Kimball and Peter Mattis
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
*
* gimpaction-history.c
app: more action search cleanup - standard copyright headers - use gtk_action_is_sensitive() not get_sensitive() - formatting
2014-02-18 23:24:48 +01:00
* Copyright (C) 2013 Jehan <jehan at girinstud.io>
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
Change the license URL from http://www.gnu.org/licenses/ to https://
2018-07-11 23:27:07 +02:00
* along with this program. If not, see <https://www.gnu.org/licenses/>.
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
*/
#include "config.h"
#include <string.h>
#include <gtk/gtk.h>
#include "libgimpbase/gimpbase.h"
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
#include "libgimpconfig/gimpconfig.h"
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
#include "libgimpmath/gimpmath.h"
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
#include "widgets-types.h"
#include "config/gimpguiconfig.h"
app: more cleanup in the action history code, mostly general consistency
2014-07-29 12:28:18 +02:00
#include "core/gimp.h"
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
#include "gimpaction.h"
#include "gimpaction-history.h"
app: more action search cleanup - standard copyright headers - use gtk_action_is_sensitive() not get_sensitive() - formatting
2014-02-18 23:24:48 +01:00
#define GIMP_ACTION_HISTORY_FILENAME "action-history"
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
/* History items are stored in a queue, sorted by frequency (number of times
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
* the action was activated), from most frequent to least frequent. Each item,
* in addition to the corresponding action name and its index in the queue,
* stores a "delta": the difference in frequency between it, and the next item
* in the queue; note that the frequency itself is not stored anywhere.
*
* To keep items from remaining at the top of the queue for too long, the delta
* is capped above, such the the maximal delta of the first item is MAX_DELTA,
* and the maximal delta of each subsequent item is the maximal delta of the
* previous item, times MAX_DELTA_FALLOFF.
*
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
* When an action is activated, its frequency grows by 1, meaning that the
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
* delta of the corresponding item is incremented (if below the maximum), and
* the delta of the previous item is decremented (if above 0). If the delta of
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
* the previous item is already 0, then, before the above, the current and
* previous items swap frequencies, and the current item is moved up the queue
* until the preceding item's frequency is greater than 0 (or until it reaches
* the front of the queue).
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
*/
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
#define MAX_DELTA 5
#define MAX_DELTA_FALLOFF 0.95
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
enum
{
HISTORY_ITEM = 1
};
app: more action search cleanup - standard copyright headers - use gtk_action_is_sensitive() not get_sensitive() - formatting
2014-02-18 23:24:48 +01:00
typedef struct
{
app: don't hold a direct reference to actions in the action history Instead, store only the action's name, and look it up upon searching. Keeping a reference to the actions in the history extended the lifetime of actions that sohuld have otherwise died, leading to all sorts of nastiness. In particular, the Alt+[n] actions to switch between images would remain bound to their accelerator after the image has been closed, holding a dangling display pointer, which would lead to a segfault, or fail with a CRITICAL message, when using the accelerator again.
2016-05-16 12:19:24 +00:00
gchar *action_name;
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
gint index;
gint delta;
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
} GimpActionHistoryItem;
app: more action search cleanup - standard copyright headers - use gtk_action_is_sensitive() not get_sensitive() - formatting
2014-02-18 23:24:48 +01:00
static struct
{
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
Gimp *gimp;
GQueue *items;
GHashTable *links;
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
} history;
app: more action search cleanup - standard copyright headers - use gtk_action_is_sensitive() not get_sensitive() - formatting
2014-02-18 23:24:48 +01:00
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
static GimpActionHistoryItem * gimp_action_history_item_new (const gchar *action_name,
gint index,
gint delta);
static void gimp_action_history_item_free (GimpActionHistoryItem *item);
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
static gint gimp_action_history_item_max_delta (gint index);
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
app: more action search cleanup - standard copyright headers - use gtk_action_is_sensitive() not get_sensitive() - formatting
2014-02-18 23:24:48 +01:00
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
/* public functions */
void
app: more cleanup in the action history code, mostly general consistency
2014-07-29 12:28:18 +02:00
gimp_action_history_init (Gimp *gimp)
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
{
app: more cleanup in the action history code, mostly general consistency
2014-07-29 12:28:18 +02:00
GimpGuiConfig *config;
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
GFile *file;
GScanner *scanner;
GTokenType token;
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
gint delta = 0;
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
app: more cleanup in the action history code, mostly general consistency
2014-07-29 12:28:18 +02:00
g_return_if_fail (GIMP_IS_GIMP (gimp));
config = GIMP_GUI_CONFIG (gimp->config);
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
if (history.gimp != NULL)
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
{
g_warning ("%s: must be run only once.", G_STRFUNC);
return;
}
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
history.gimp = gimp;
history.items = g_queue_new ();
history.links = g_hash_table_new (g_str_hash, g_str_equal);
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
file = gimp_directory_file (GIMP_ACTION_HISTORY_FILENAME, NULL);
app: add --verbose output when parsing and writing the action history
2014-07-29 18:13:57 +02:00
if (gimp->be_verbose)
g_print ("Parsing '%s'\n", gimp_file_get_utf8_name (file));
libgimpconfig: get rid of filenames in all config related APIs and rename function names which say "gfile" to just "file".
2019-09-21 12:53:38 +02:00
scanner = gimp_scanner_new_file (file, NULL);
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
g_object_unref (file);
app: more action search cleanup - standard copyright headers - use gtk_action_is_sensitive() not get_sensitive() - formatting
2014-02-18 23:24:48 +01:00
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
if (! scanner)
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
return;
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
g_scanner_scope_add_symbol (scanner, 0, "history-item",
GINT_TO_POINTER (HISTORY_ITEM));
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
token = G_TOKEN_LEFT_PAREN;
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
while (g_scanner_peek_next_token (scanner) == token)
{
token = g_scanner_get_next_token (scanner);
app: some serious cleanup in gimpaction-history.c, still a lot to do
2014-07-28 11:22:20 +02:00
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
switch (token)
app: some serious cleanup in gimpaction-history.c, still a lot to do
2014-07-28 11:22:20 +02:00
{
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
case G_TOKEN_LEFT_PAREN:
token = G_TOKEN_SYMBOL;
break;
case G_TOKEN_SYMBOL:
if (scanner->value.v_symbol == GINT_TO_POINTER (HISTORY_ITEM))
{
app: don't hold a direct reference to actions in the action history Instead, store only the action's name, and look it up upon searching. Keeping a reference to the actions in the history extended the lifetime of actions that sohuld have otherwise died, leading to all sorts of nastiness. In particular, the Alt+[n] actions to switch between images would remain bound to their accelerator after the image has been closed, holding a dangling display pointer, which would lead to a segfault, or fail with a CRITICAL message, when using the accelerator again.
2016-05-16 12:19:24 +00:00
gchar *action_name;
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
token = G_TOKEN_STRING;
if (g_scanner_peek_next_token (scanner) != token)
break;
app: don't hold a direct reference to actions in the action history Instead, store only the action's name, and look it up upon searching. Keeping a reference to the actions in the history extended the lifetime of actions that sohuld have otherwise died, leading to all sorts of nastiness. In particular, the Alt+[n] actions to switch between images would remain bound to their accelerator after the image has been closed, holding a dangling display pointer, which would lead to a segfault, or fail with a CRITICAL message, when using the accelerator again.
2016-05-16 12:19:24 +00:00
if (! gimp_scanner_parse_string (scanner, &action_name))
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
break;
token = G_TOKEN_INT;
app: don't hold a direct reference to actions in the action history Instead, store only the action's name, and look it up upon searching. Keeping a reference to the actions in the history extended the lifetime of actions that sohuld have otherwise died, leading to all sorts of nastiness. In particular, the Alt+[n] actions to switch between images would remain bound to their accelerator after the image has been closed, holding a dangling display pointer, which would lead to a segfault, or fail with a CRITICAL message, when using the accelerator again.
2016-05-16 12:19:24 +00:00
if (g_scanner_peek_next_token (scanner) != token ||
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
! gimp_scanner_parse_int (scanner, &delta))
app: don't hold a direct reference to actions in the action history Instead, store only the action's name, and look it up upon searching. Keeping a reference to the actions in the history extended the lifetime of actions that sohuld have otherwise died, leading to all sorts of nastiness. In particular, the Alt+[n] actions to switch between images would remain bound to their accelerator after the image has been closed, holding a dangling display pointer, which would lead to a segfault, or fail with a CRITICAL message, when using the accelerator again.
2016-05-16 12:19:24 +00:00
{
g_free (action_name);
break;
}
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
if (! gimp_action_history_is_excluded_action (action_name) &&
! g_hash_table_contains (history.links, action_name))
app: don't add blacklisted/excluded actions to the action history gimp_action_history_init(): when deserializing the action history, check each action against gimp_action_history_excluded_action() so when we decide to exclude an action, it doesn't come back as history zombie from disk.
2018-01-13 21:26:27 +01:00
{
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
GimpActionHistoryItem *item;
item = gimp_action_history_item_new (
action_name,
g_queue_get_length (history.items),
delta);
g_queue_push_tail (history.items, item);
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
g_hash_table_insert (history.links,
item->action_name,
g_queue_peek_tail_link (history.items));
app: don't add blacklisted/excluded actions to the action history gimp_action_history_init(): when deserializing the action history, check each action against gimp_action_history_excluded_action() so when we decide to exclude an action, it doesn't come back as history zombie from disk.
2018-01-13 21:26:27 +01:00
}
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
app: don't hold a direct reference to actions in the action history Instead, store only the action's name, and look it up upon searching. Keeping a reference to the actions in the history extended the lifetime of actions that sohuld have otherwise died, leading to all sorts of nastiness. In particular, the Alt+[n] actions to switch between images would remain bound to their accelerator after the image has been closed, holding a dangling display pointer, which would lead to a segfault, or fail with a CRITICAL message, when using the accelerator again.
2016-05-16 12:19:24 +00:00
g_free (action_name);
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
}
token = G_TOKEN_RIGHT_PAREN;
break;
case G_TOKEN_RIGHT_PAREN:
token = G_TOKEN_LEFT_PAREN;
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
if (g_queue_get_length (history.items) >= config->action_history_size)
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
goto done;
break;
default: /* do nothing */
break;
app: some serious cleanup in gimpaction-history.c, still a lot to do
2014-07-28 11:22:20 +02:00
}
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
}
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
done:
libgimpconfig: add a GimpScanner typedef and make it a boxed type Replace _destroy() by _ref() and _unref().
2019-08-09 12:42:52 +02:00
gimp_scanner_unref (scanner);
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
}
void
app: more cleanup in the action history code, mostly general consistency
2014-07-29 12:28:18 +02:00
gimp_action_history_exit (Gimp *gimp)
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
{
app: more cleanup in the action history code, mostly general consistency
2014-07-29 12:28:18 +02:00
GimpGuiConfig *config;
app: some serious cleanup in gimpaction-history.c, still a lot to do
2014-07-28 11:22:20 +02:00
GimpActionHistoryItem *item;
GList *actions;
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
GFile *file;
GimpConfigWriter *writer;
app: some serious cleanup in gimpaction-history.c, still a lot to do
2014-07-28 11:22:20 +02:00
gint i;
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
app: more cleanup in the action history code, mostly general consistency
2014-07-29 12:28:18 +02:00
g_return_if_fail (GIMP_IS_GIMP (gimp));
config = GIMP_GUI_CONFIG (gimp->config);
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
file = gimp_directory_file (GIMP_ACTION_HISTORY_FILENAME, NULL);
app: add --verbose output when parsing and writing the action history
2014-07-29 18:13:57 +02:00
if (gimp->be_verbose)
g_print ("Writing '%s'\n", gimp_file_get_utf8_name (file));
libgimpconfig: get rid of filenames in all config related APIs and rename function names which say "gfile" to just "file".
2019-09-21 12:53:38 +02:00
writer = gimp_config_writer_new_from_file (file, TRUE, "GIMP action-history",
NULL);
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
g_object_unref (file);
app: some serious cleanup in gimpaction-history.c, still a lot to do
2014-07-28 11:22:20 +02:00
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
for (actions = history.items->head, i = 0;
app: some serious cleanup in gimpaction-history.c, still a lot to do
2014-07-28 11:22:20 +02:00
actions && i < config->action_history_size;
actions = g_list_next (actions), i++)
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
{
app: some serious cleanup in gimpaction-history.c, still a lot to do
2014-07-28 11:22:20 +02:00
item = actions->data;
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
gimp_config_writer_open (writer, "history-item");
app: don't hold a direct reference to actions in the action history Instead, store only the action's name, and look it up upon searching. Keeping a reference to the actions in the history extended the lifetime of actions that sohuld have otherwise died, leading to all sorts of nastiness. In particular, the Alt+[n] actions to switch between images would remain bound to their accelerator after the image has been closed, holding a dangling display pointer, which would lead to a segfault, or fail with a CRITICAL message, when using the accelerator again.
2016-05-16 12:19:24 +00:00
gimp_config_writer_string (writer, item->action_name);
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
gimp_config_writer_printf (writer, "%d", item->delta);
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
gimp_config_writer_close (writer);
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
}
app: port the action history to GimpConfigWriter, GimpScanner and to GIO which means the file format has changed, but it will silently ignore the parse error when encountering the old format.
2014-07-28 16:44:44 +02:00
gimp_config_writer_finish (writer, "end of action-history", NULL);
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
app: more cleanup in the action history code, mostly general consistency
2014-07-29 12:28:18 +02:00
gimp_action_history_clear (gimp);
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
g_clear_pointer (&history.links, g_hash_table_unref);
g_clear_pointer (&history.items, g_queue_free);
history.gimp = NULL;
app: more cleanup in the action history code, mostly general consistency
2014-07-29 12:28:18 +02:00
}
void
gimp_action_history_clear (Gimp *gimp)
{
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
GimpActionHistoryItem *item;
app: more cleanup in the action history code, mostly general consistency
2014-07-29 12:28:18 +02:00
g_return_if_fail (GIMP_IS_GIMP (gimp));
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
g_hash_table_remove_all (history.links);
while ((item = g_queue_pop_head (history.items)))
gimp_action_history_item_free (item);
app: more cleanup in the action history code, mostly general consistency
2014-07-29 12:28:18 +02:00
}
app: show unavailable actions in Action Search after available ones. Some people had been complaining that they couldn't find some actions in some case, which was only because they were in states where the actions were non-sensitive. So it was "normal" (i.e. not a bug), yet I can see how it can be disturbing especially when we don't realize that an action is meant to be inactive in some given case. Of course the option to show all actions already existed in the Preferences. But as most options in Preferences, this is hardly discoverable and many people only use default settings. Moreover showing hidden action made the action search cluttered with non-sensitive actions in the middle of sensitive ones. This change gets rid of the "Show unavailable actions" settings and always show all matching actions. In order not to clutter the list with useless results, I simply updated the display logics to always show non-sensitive action after sensitive ones. Note that even non-sensitive actions will still be ordered in a better-match-on-top logics, yet they will be after sensitive actions. So the top results will be the best matches among sensitive actions (action in history), followed by various levels of matches (actions with matching labels, tooltips, different order matches, etc.); then they will be followed by best matches among non-sensitive actions, followed by the same levels of matches as sensitive ones. This way, we still keep a very relevant result and there is no need to have a settings for this.
2020-10-26 16:40:19 +01:00
/**
* gimp_action_history_search:
* @gimp:
* @match_func:
* @keyword:
app: more cleanup in the action history code, mostly general consistency
2014-07-29 12:28:18 +02:00
*
app: show unavailable actions in Action Search after available ones. Some people had been complaining that they couldn't find some actions in some case, which was only because they were in states where the actions were non-sensitive. So it was "normal" (i.e. not a bug), yet I can see how it can be disturbing especially when we don't realize that an action is meant to be inactive in some given case. Of course the option to show all actions already existed in the Preferences. But as most options in Preferences, this is hardly discoverable and many people only use default settings. Moreover showing hidden action made the action search cluttered with non-sensitive actions in the middle of sensitive ones. This change gets rid of the "Show unavailable actions" settings and always show all matching actions. In order not to clutter the list with useless results, I simply updated the display logics to always show non-sensitive action after sensitive ones. Note that even non-sensitive actions will still be ordered in a better-match-on-top logics, yet they will be after sensitive actions. So the top results will be the best matches among sensitive actions (action in history), followed by various levels of matches (actions with matching labels, tooltips, different order matches, etc.); then they will be followed by best matches among non-sensitive actions, followed by the same levels of matches as sensitive ones. This way, we still keep a very relevant result and there is no need to have a settings for this.
2020-10-26 16:40:19 +01:00
* Search all history #GimpAction which match @keyword with function
* @match_func(action, keyword).
* It will also return inactive actions, but will discard non-visible
* actions.
*
* returns: a #GList of #GimpAction, which must be freed with
* g_list_free_full (result, (GDestroyNotify) g_object_unref)
app: more cleanup in the action history code, mostly general consistency
2014-07-29 12:28:18 +02:00
*/
GList *
gimp_action_history_search (Gimp *gimp,
GimpActionMatchFunc match_func,
const gchar *keyword)
{
GimpGuiConfig *config;
GList *actions;
GList *result = NULL;
gint i;
g_return_val_if_fail (GIMP_IS_GIMP (gimp), NULL);
g_return_val_if_fail (match_func != NULL, NULL);
app: don't hold a direct reference to actions in the action history Instead, store only the action's name, and look it up upon searching. Keeping a reference to the actions in the history extended the lifetime of actions that sohuld have otherwise died, leading to all sorts of nastiness. In particular, the Alt+[n] actions to switch between images would remain bound to their accelerator after the image has been closed, holding a dangling display pointer, which would lead to a segfault, or fail with a CRITICAL message, when using the accelerator again.
2016-05-16 12:19:24 +00:00
config = GIMP_GUI_CONFIG (gimp->config);
app: more cleanup in the action history code, mostly general consistency
2014-07-29 12:28:18 +02:00
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
for (actions = history.items->head, i = 0;
app: more cleanup in the action history code, mostly general consistency
2014-07-29 12:28:18 +02:00
actions && i < config->action_history_size;
actions = g_list_next (actions), i++)
{
app: Action Search does not use GimpUiManager anymore. It directly uses the action added to the GtkApplication/GActionMap.
2023-01-30 00:19:32 +01:00
GimpActionHistoryItem *item = actions->data;
GAction *action;
app: don't hold a direct reference to actions in the action history Instead, store only the action's name, and look it up upon searching. Keeping a reference to the actions in the history extended the lifetime of actions that sohuld have otherwise died, leading to all sorts of nastiness. In particular, the Alt+[n] actions to switch between images would remain bound to their accelerator after the image has been closed, holding a dangling display pointer, which would lead to a segfault, or fail with a CRITICAL message, when using the accelerator again.
2016-05-16 12:19:24 +00:00
app: Action Search does not use GimpUiManager anymore. It directly uses the action added to the GtkApplication/GActionMap.
2023-01-30 00:19:32 +01:00
action = g_action_map_lookup_action (G_ACTION_MAP (gimp->app), item->action_name);
Bug 774890 - "Keyboard shortcuts" dialog does not show all actions Revert "app: action search should search accross all available actions." This reverts commit 53b3673bd8ce96c67ce05de69fe43bc0b87d15a8. Had to revert these two commits, quoting comment 6 of the bug: Thinking again, that entire change is unfortunately wrong, the only right UI manager is in fact gimp_ui_managers_from_name ("<Image>")->data because it's the global popup <Image> UI manager which is independent of a display and it always in the right state for the currently active image, all other UI managers are wrong.
2016-11-24 21:08:34 +01:00
if (action == NULL)
continue;
app: more cleanup in the action history code, mostly general consistency
2014-07-29 12:28:18 +02:00
app: Action Search does not use GimpUiManager anymore. It directly uses the action added to the GtkApplication/GActionMap.
2023-01-30 00:19:32 +01:00
g_return_val_if_fail (GIMP_IS_ACTION (action), NULL);
if (! gimp_action_is_visible (GIMP_ACTION (action)))
app: more cleanup in the action history code, mostly general consistency
2014-07-29 12:28:18 +02:00
continue;
app: Action Search does not use GimpUiManager anymore. It directly uses the action added to the GtkApplication/GActionMap.
2023-01-30 00:19:32 +01:00
if (match_func (GIMP_ACTION (action), keyword, NULL, gimp))
app: more cleanup in the action history code, mostly general consistency
2014-07-29 12:28:18 +02:00
result = g_list_prepend (result, g_object_ref (action));
}
return g_list_reverse (result);
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
}
app: add gimp_action_history_is_blacklisted_action() ... and rename gimp_action_history_excluded_action() to gimp_action_history_is_excluded_action(). is_blacklisted_action() determines whether an action should be excluded from *both* the history and the search results, while is_excluded_action() determines if an action should be excluded only from the history. This eliminates some redundancy across gimpaction-history and action-search-dialog.
2018-02-17 04:27:24 -05:00
/* gimp_action_history_is_blacklisted_action:
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
*
app: add gimp_action_history_is_blacklisted_action() ... and rename gimp_action_history_excluded_action() to gimp_action_history_is_excluded_action(). is_blacklisted_action() determines whether an action should be excluded from *both* the history and the search results, while is_excluded_action() determines if an action should be excluded only from the history. This eliminates some redundancy across gimpaction-history and action-search-dialog.
2018-02-17 04:27:24 -05:00
* Returns whether an action should be excluded from both
* history and search results.
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
*/
gboolean
app: add gimp_action_history_is_blacklisted_action() ... and rename gimp_action_history_excluded_action() to gimp_action_history_is_excluded_action(). is_blacklisted_action() determines whether an action should be excluded from *both* the history and the search results, while is_excluded_action() determines if an action should be excluded only from the history. This eliminates some redundancy across gimpaction-history and action-search-dialog.
2018-02-17 04:27:24 -05:00
gimp_action_history_is_blacklisted_action (const gchar *action_name)
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
{
app: add gimp_action_is_gui_blacklisted() which filters out some implementation details but mainly all the tool-specific options actions which only exist as redirect targets for the generic tool opaticy, size, aspect and angle actions. Use the new function from the shortcut editor and from action search so stuff is consistently hidden.
2014-04-20 15:57:57 +02:00
if (gimp_action_is_gui_blacklisted (action_name))
return TRUE;
return (g_str_has_suffix (action_name, "-set") ||
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
g_str_has_prefix (action_name, "context-") ||
widgets: Do not show internal procedures as search actions Resolves #11334 GBR, GIH, and PAT have internal save functions which are not meant to be run directly. However, they were showing up in the Search dialogue as valid options. This patch adds an additional check for "-internal" to prevent users from accidentally running them, as they only give a warning.
2024-04-17 17:10:18 +00:00
g_str_has_suffix (action_name, "-internal") ||
app: remove the "Recent Filters" actions from action search again The code was still checking for "plug-in-recent-*". Also, rename the actions to "filters-recent-*" instead of "filter-recent-*" for consistency with the other filters actions.
2016-11-03 22:37:13 +01:00
g_str_has_prefix (action_name, "filters-recent-") ||
app: "help-action-search" has been renamed to "dialogs-action-search"... ... since commits 36f87b5b and 2b6a10b7. With the renaming, action-search was showing itself in its list.
2016-09-12 01:49:08 +02:00
g_strcmp0 (action_name, "dialogs-action-search") == 0);
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
}
app: add gimp_action_history_is_blacklisted_action() ... and rename gimp_action_history_excluded_action() to gimp_action_history_is_excluded_action(). is_blacklisted_action() determines whether an action should be excluded from *both* the history and the search results, while is_excluded_action() determines if an action should be excluded only from the history. This eliminates some redundancy across gimpaction-history and action-search-dialog.
2018-02-17 04:27:24 -05:00
/* gimp_action_history_is_excluded_action:
*
* Returns whether an action should be excluded from history.
*
* Some actions should not be logged in the history, but should
* otherwise appear in the search results, since they correspond
app: exclude undo/redo actions from history The undo/redo actions' label changes based on context, and may interfere with the labels of more relevant, but less frequent, actions. For example, after applying filter Foo, the label of edit-undo becomes "Undo Foo", so searching for "Foo" results in both edit-undo, and the action referring to the filter, with edit-undo most likely appearing at the top of the list due to its frequency. Excluding the undo/redo actions from the history is a simple, if suboptimal, way to fix this.
2018-02-17 04:30:51 -05:00
* to different functions at different times, or since their
* label may interfere with more relevant, but less frequent,
* actions.
app: add gimp_action_history_is_blacklisted_action() ... and rename gimp_action_history_excluded_action() to gimp_action_history_is_excluded_action(). is_blacklisted_action() determines whether an action should be excluded from *both* the history and the search results, while is_excluded_action() determines if an action should be excluded only from the history. This eliminates some redundancy across gimpaction-history and action-search-dialog.
2018-02-17 04:27:24 -05:00
*/
gboolean
gimp_action_history_is_excluded_action (const gchar *action_name)
{
if (gimp_action_history_is_blacklisted_action (action_name))
return TRUE;
app: exclude undo/redo actions from history The undo/redo actions' label changes based on context, and may interfere with the labels of more relevant, but less frequent, actions. For example, after applying filter Foo, the label of edit-undo becomes "Undo Foo", so searching for "Foo" results in both edit-undo, and the action referring to the filter, with edit-undo most likely appearing at the top of the list due to its frequency. Excluding the undo/redo actions from the history is a simple, if suboptimal, way to fix this.
2018-02-17 04:30:51 -05:00
return (g_strcmp0 (action_name, "edit-undo") == 0 ||
g_strcmp0 (action_name, "edit-strong-undo") == 0 ||
g_strcmp0 (action_name, "edit-redo") == 0 ||
g_strcmp0 (action_name, "edit-strong-redo") == 0 ||
g_strcmp0 (action_name, "filters-repeat") == 0 ||
app: add gimp_action_history_is_blacklisted_action() ... and rename gimp_action_history_excluded_action() to gimp_action_history_is_excluded_action(). is_blacklisted_action() determines whether an action should be excluded from *both* the history and the search results, while is_excluded_action() determines if an action should be excluded only from the history. This eliminates some redundancy across gimpaction-history and action-search-dialog.
2018-02-17 04:27:24 -05:00
g_strcmp0 (action_name, "filters-reshow") == 0);
}
app: log actions upon activation before emitting "selected" signal In GimpAction, instead of connecting the action-history log function to the action's "activate" signal as a user-provided handler, call it directly from the default handler. In subclasses of GimpAction, chain to the parent's activate() function before emitting the "selected" signal, so that we always log the action in the history before responding to it. This allows us to avoid the hack in commit 6544ce4301fa43636b4c282c7b4815e18fd653d1.
2018-07-06 00:00:16 -04:00
/* Called whenever a GimpAction is activated.
* It allows us to log all used actions.
app: more action search cleanup - standard copyright headers - use gtk_action_is_sensitive() not get_sensitive() - formatting
2014-02-18 23:24:48 +01:00
*/
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
void
app: start porting away from GtkAction and friends Step one: get rid of all those deprecation warnings that make it hard to see any other warnings: - add a lot of dummy API to GimpAction, GimpActionGroup, GimpUIManager etc. which simply forwards to the deprecated GTK functions, they will all go away again later - rename GimpAction to GimpActionImpl - add interface GimpAction that is implemented by all action classes, creates a common interface and allows to remove some duplicated logic from GimpToggleAction and GimpRadioAction, and at the same time adds more features
2019-07-02 03:54:38 +02:00
gimp_action_history_action_activated (GimpAction *action)
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
{
app: fix potential segfault in gimp_action_history_activate_callback() In gimp_action_history_activate_callback(), bail if history.gimp is NULL, instead of dereferencing it. This can happen if GIMP is shut down during the execution of a temporary procedure, such as a script-fu script. See the code comment for details.
2018-07-05 13:27:02 -04:00
GimpGuiConfig *config;
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
const gchar *action_name;
GList *link;
GimpActionHistoryItem *item;
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
app: do not assume that a procedure is still registered after running. I had the case when "Sphere" script crashed, bringing down the whole script-fu plug-in (while trying to reproduce #10214). Then after being run, we get a dangling pointer to a finalized action object. Even in successful use cases, we will want to give the ability to unregister normal plug-ins/procedures wrapped as GIMP extensions, and there is also the use case of temporary procedures, so I'm sure this bug could be reproducible even in normal non-problematic runs.
2023-10-26 22:36:16 +02:00
g_return_if_fail (GIMP_IS_ACTION (action));
app: don't warn in gimp_action_history_action_activated() if there is no "gimp". Happened after the action changes when invoking the "quit" action.
2019-07-04 17:04:33 +02:00
/* Silently return when called at the wrong time, like when the
* activated action was "quit" and the history is already gone.
*/
if (! history.gimp)
return;
app: fix potential segfault in gimp_action_history_activate_callback() In gimp_action_history_activate_callback(), bail if history.gimp is NULL, instead of dereferencing it. This can happen if GIMP is shut down during the execution of a temporary procedure, such as a script-fu script. See the code comment for details.
2018-07-05 13:27:02 -04:00
config = GIMP_GUI_CONFIG (history.gimp->config);
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
if (config->action_history_size == 0)
return;
app: start porting away from GtkAction and friends Step one: get rid of all those deprecation warnings that make it hard to see any other warnings: - add a lot of dummy API to GimpAction, GimpActionGroup, GimpUIManager etc. which simply forwards to the deprecated GTK functions, they will all go away again later - rename GimpAction to GimpActionImpl - add interface GimpAction that is implemented by all action classes, creates a common interface and allows to remove some duplicated logic from GimpToggleAction and GimpRadioAction, and at the same time adds more features
2019-07-02 03:54:38 +02:00
action_name = gimp_action_get_name (action);
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
/* Some specific actions are of no log interest. */
app: add gimp_action_history_is_blacklisted_action() ... and rename gimp_action_history_excluded_action() to gimp_action_history_is_excluded_action(). is_blacklisted_action() determines whether an action should be excluded from *both* the history and the search results, while is_excluded_action() determines if an action should be excluded only from the history. This eliminates some redundancy across gimpaction-history and action-search-dialog.
2018-02-17 04:27:24 -05:00
if (gimp_action_history_is_excluded_action (action_name))
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
return;
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
g_return_if_fail (action_name != NULL);
/* Remove excessive items. */
while (g_queue_get_length (history.items) > config->action_history_size)
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
{
item = g_queue_pop_tail (history.items);
g_hash_table_remove (history.links, item->action_name);
gimp_action_history_item_free (item);
}
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
/* Look up the action in the history. */
link = g_hash_table_lookup (history.links, action_name);
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
/* If the action is not in the history, insert it
Bug 794996 - Misc. typo fixes in comments in app/ Found via `codespell -q 3 --skip="./po*"`
2018-03-24 16:49:01 -04:00
* at the back of the history queue, possibly
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
* replacing the last item.
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
*/
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
if (! link)
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
{
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
if (g_queue_get_length (history.items) == config->action_history_size)
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
{
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
item = g_queue_pop_tail (history.items);
app: some serious cleanup in gimpaction-history.c, still a lot to do
2014-07-28 11:22:20 +02:00
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
g_hash_table_remove (history.links, item->action_name);
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
gimp_action_history_item_free (item);
}
app: some serious cleanup in gimpaction-history.c, still a lot to do
2014-07-28 11:22:20 +02:00
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
item = gimp_action_history_item_new (
action_name,
g_queue_get_length (history.items),
0);
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
g_queue_push_tail (history.items, item);
link = g_queue_peek_tail_link (history.items);
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
g_hash_table_insert (history.links, item->action_name, link);
}
else
{
item = link->data;
}
app: some serious cleanup in gimpaction-history.c, still a lot to do
2014-07-28 11:22:20 +02:00
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
/* Update the history, according to the logic described
* in the comment at the beginning of the file.
*/
if (item->index > 0)
{
GList *prev_link = g_list_previous (link);
GimpActionHistoryItem *prev_item = prev_link->data;
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
if (prev_item->delta == 0)
{
for (; prev_link; prev_link = g_list_previous (prev_link))
{
prev_item = prev_link->data;
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
if (prev_item->delta > 0)
break;
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
prev_item->index++;
item->index--;
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
prev_item->delta = item->delta;
item->delta = 0;
}
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
g_queue_unlink (history.items, link);
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
if (prev_link)
{
link->prev = prev_link;
link->next = prev_link->next;
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
link->prev->next = link;
link->next->prev = link;
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
history.items->length++;
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
}
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
else
{
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
g_queue_push_head_link (history.items, link);
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
}
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
}
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
if (item->index > 0)
prev_item->delta--;
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
}
app: more action history sorting logic improvements/fixes Simplify the action history sorting logic introduced in the previous commit, and fix a few issues in its implementation.
2018-02-17 10:01:52 -05:00
if (item->delta < gimp_action_history_item_max_delta (item->index))
item->delta++;
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
}
app: some serious cleanup in gimpaction-history.c, still a lot to do
2014-07-28 11:22:20 +02:00
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
/* private functions */
app: some serious cleanup in gimpaction-history.c, still a lot to do
2014-07-28 11:22:20 +02:00
static GimpActionHistoryItem *
app: don't hold a direct reference to actions in the action history Instead, store only the action's name, and look it up upon searching. Keeping a reference to the actions in the history extended the lifetime of actions that sohuld have otherwise died, leading to all sorts of nastiness. In particular, the Alt+[n] actions to switch between images would remain bound to their accelerator after the image has been closed, holding a dangling display pointer, which would lead to a segfault, or fail with a CRITICAL message, when using the accelerator again.
2016-05-16 12:19:24 +00:00
gimp_action_history_item_new (const gchar *action_name,
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
gint index,
gint delta)
app: some serious cleanup in gimpaction-history.c, still a lot to do
2014-07-28 11:22:20 +02:00
{
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
GimpActionHistoryItem *item = g_slice_new (GimpActionHistoryItem);
app: some serious cleanup in gimpaction-history.c, still a lot to do
2014-07-28 11:22:20 +02:00
app: don't hold a direct reference to actions in the action history Instead, store only the action's name, and look it up upon searching. Keeping a reference to the actions in the history extended the lifetime of actions that sohuld have otherwise died, leading to all sorts of nastiness. In particular, the Alt+[n] actions to switch between images would remain bound to their accelerator after the image has been closed, holding a dangling display pointer, which would lead to a segfault, or fail with a CRITICAL message, when using the accelerator again.
2016-05-16 12:19:24 +00:00
item->action_name = g_strdup (action_name);
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
item->index = index;
item->delta = CLAMP (delta, 0, gimp_action_history_item_max_delta (index));
app: some serious cleanup in gimpaction-history.c, still a lot to do
2014-07-28 11:22:20 +02:00
return item;
}
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
static void
gimp_action_history_item_free (GimpActionHistoryItem *item)
{
app: don't hold a direct reference to actions in the action history Instead, store only the action's name, and look it up upon searching. Keeping a reference to the actions in the history extended the lifetime of actions that sohuld have otherwise died, leading to all sorts of nastiness. In particular, the Alt+[n] actions to switch between images would remain bound to their accelerator after the image has been closed, holding a dangling display pointer, which would lead to a segfault, or fail with a CRITICAL message, when using the accelerator again.
2016-05-16 12:19:24 +00:00
g_free (item->action_name);
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
g_slice_free (GimpActionHistoryItem, item);
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
}
static gint
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
gimp_action_history_item_max_delta (gint index)
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
{
app: improve action history sorting The current sorting logic of actions in the history is essentially linear, so that when an action is activated it moves up one place in the history. This has the undesirable effect that actions take very long to climb up the history list, as well as that actions at the top of the list can change their relative order too frequently. Improve the sorting logic, such that items climb up the list faster, while top items retain their relative position longer. See the comment at the top of the diff for the actual logic.
2018-02-17 08:02:29 -05:00
return floor (MAX_DELTA * exp (log (MAX_DELTA_FALLOFF) * index));
Bug 708174 - Improve the original search dialog patch. Fix various bugs, improve code design and efficiency, change feature name, update the feature up to our standards (now uses GIMP preferences, session management, less overwhelming settings...). Also now action history is tightly tied to GimpAction and logs all action activation (however it activates, and the show_unavailable parameter also applies to history). Search algorithm greatly improved with basic tokenization, better ordering, filtering, etc.
2013-09-26 06:02:59 +12:00
}
Reference in a new issue Copy permalink