diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 48a9310bddc..d4cded58084 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,9 @@ +2013-06-14 Paolo Carlini + + PR c++/57599 + * rtti.c (build_dynamic_cast_1): In case of cast to an unambiguous + accessible base simply forward to build_static_cast. + 2013-06-12 Paolo Carlini PR c++/38958 diff --git a/gcc/cp/rtti.c b/gcc/cp/rtti.c index 90104406dff..f3094981dfb 100644 --- a/gcc/cp/rtti.c +++ b/gcc/cp/rtti.c @@ -622,19 +622,10 @@ build_dynamic_cast_1 (tree type, tree expr, tsubst_flags_t complain) /* If *type is an unambiguous accessible base class of *exprtype, convert statically. */ { - tree binfo; - - binfo = lookup_base (TREE_TYPE (exprtype), TREE_TYPE (type), - ba_check, NULL, complain); - + tree binfo = lookup_base (TREE_TYPE (exprtype), TREE_TYPE (type), + ba_check, NULL, complain); if (binfo) - { - expr = build_base_path (PLUS_EXPR, convert_from_reference (expr), - binfo, 0, complain); - if (TYPE_PTR_P (exprtype)) - expr = rvalue (expr); - return expr; - } + return build_static_cast (type, expr, complain); } /* Otherwise *exprtype must be a polymorphic class (have a vtbl). */ diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index a209086b41b..119a7648c7d 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2013-06-14 Paolo Carlini + + PR c++/57599 + * g++.dg/rtti/dyncast6.C: New. + * g++.dg/cpp0x/dyncast1.C: Likewise. + 2013-06-14 Alan Modra PR middle-end/57134 diff --git a/gcc/testsuite/g++.dg/cpp0x/dyncast1.C b/gcc/testsuite/g++.dg/cpp0x/dyncast1.C new file mode 100644 index 00000000000..1224f361ff3 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp0x/dyncast1.C @@ -0,0 +1,31 @@ +// PR c++/57599 +// { dg-do compile { target c++11 } } + +struct A { }; +struct B : public A { }; + +template +struct is_same { static constexpr bool value = false; }; + +template +struct is_same { static constexpr bool value = true; }; + +template +T val(); + +static_assert(is_same(val())), + A*>::value, "Ouch"); +static_assert(is_same(val())), + A&>::value, "Ouch"); +static_assert(is_same(val())), + const A*>::value, "Ouch"); +static_assert(is_same(val())), + const A&>::value, "Ouch"); +static_assert(is_same(val())), + volatile A*>::value, "Ouch"); +static_assert(is_same(val())), + volatile A&>::value, "Ouch"); +static_assert(is_same(val())), + const volatile A*>::value, "Ouch"); +static_assert(is_same(val())), + const volatile A&>::value, "Ouch"); diff --git a/gcc/testsuite/g++.dg/rtti/dyncast6.C b/gcc/testsuite/g++.dg/rtti/dyncast6.C new file mode 100644 index 00000000000..a6329e9441c --- /dev/null +++ b/gcc/testsuite/g++.dg/rtti/dyncast6.C @@ -0,0 +1,59 @@ +// PR c++/57599 + +class A { }; + +class B : public A { }; + +void p() +{ + B* b; + + A* a1; + a1 = dynamic_cast(b); + a1 = dynamic_cast(b); // { dg-error "invalid" } + a1 = dynamic_cast(b); // { dg-error "invalid" } + a1 = dynamic_cast(b); // { dg-error "invalid" } + + const A* a2; + a2 = dynamic_cast(b); + a2 = dynamic_cast(b); + a2 = dynamic_cast(b); // { dg-error "invalid" } + a2 = dynamic_cast(b); // { dg-error "invalid" } + + volatile A* a3; + a3 = dynamic_cast(b); + a3 = dynamic_cast(b); // { dg-error "invalid" } + a3 = dynamic_cast(b); + a3 = dynamic_cast(b); // { dg-error "invalid" } + + const volatile A* a4; + a4 = dynamic_cast(b); + a4 = dynamic_cast(b); + a4 = dynamic_cast(b); + a4 = dynamic_cast(b); +} + +void r() +{ + B b; + + A& a1 = dynamic_cast(b); + A& a2 = dynamic_cast(b); // { dg-error "invalid" } + A& a3 = dynamic_cast(b); // { dg-error "invalid" } + A& a4 = dynamic_cast(b); // { dg-error "invalid" } + + const A& ca1 = dynamic_cast(b); + const A& ca2 = dynamic_cast(b); + const A& ca3 = dynamic_cast(b); // { dg-error "invalid" } + const A& ca4 = dynamic_cast(b); // { dg-error "invalid" } + + volatile A& va1 = dynamic_cast(b); + volatile A& va2 = dynamic_cast(b); // { dg-error "invalid" } + volatile A& va3 = dynamic_cast(b); + volatile A& va4 = dynamic_cast(b);// { dg-error "invalid" } + + const volatile A& cva1 = dynamic_cast(b); + const volatile A& cva2 = dynamic_cast(b); + const volatile A& cva3 = dynamic_cast(b); + const volatile A& cva4 = dynamic_cast(b); +}