procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

decl2.c (grokbitfield): Use DECL_SOURCE_LOCATION in error messages about bit-fields with function type...

Browse source 
/cp
2018-12-07  Paolo Carlini  <paolo.carlini@oracle.com>

	* decl2.c (grokbitfield): Use DECL_SOURCE_LOCATION in error messages
	about bit-fields with function type, warn_if_not_aligned type, and
	static bit-fields; avoid DECL_NAME for unnamed declarations.

/testsuite
2018-12-07  Paolo Carlini  <paolo.carlini@oracle.com>

	* g++.dg/other/bitfield7.C: New.
	* g++.dg/parse/bitfield8.C: Likewise.
	* g++.dg/parse/bitfield9.C: Likewise.
	* g++.dg/pr53037-4.C: Test the locations too.

From-SVN: r266900
This commit is contained in:
Paolo Carlini 2018-12-07 17:48:39 +00:00 • committed by Paolo Carlini
parent 96e14fda0d
commit fee11e77e5
7 changed files with 39 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gcc/cp/ChangeLog
View file

@ -1,3 +1,9 @@
2018-12-07 Paolo Carlini <paolo.carlini@oracle.com>
* decl2.c (grokbitfield): Use DECL_SOURCE_LOCATION in error messages
about bit-fields with function type, warn_if_not_aligned type, and
static bit-fields; avoid DECL_NAME for unnamed declarations.
2018-12-07 Jakub Jelinek <jakub@redhat.com>
PR c++/86669

13
gcc/cp/decl2.c
View file

@ -1046,15 +1046,15 @@ grokbitfield (const cp_declarator *declarator,
check here. */
if (TREE_CODE (value) == FUNCTION_DECL)
{
error ("cannot declare bit-field %qD with function type",
DECL_NAME (value));
error_at (DECL_SOURCE_LOCATION (value),
"cannot declare bit-field %qD with function type", value);
return NULL_TREE;
}
if (width && TYPE_WARN_IF_NOT_ALIGN (type))
if (TYPE_WARN_IF_NOT_ALIGN (type))
{
error ("cannot declare bit-field %qD with %<warn_if_not_aligned%> type",
DECL_NAME (value));
error_at (DECL_SOURCE_LOCATION (value), "cannot declare bit-field "
"%qD with %<warn_if_not_aligned%> type", value);
return NULL_TREE;
}
@ -1067,7 +1067,8 @@ grokbitfield (const cp_declarator *declarator,
if (TREE_STATIC (value))
{
error ("static member %qD cannot be a bit-field", value);
error_at (DECL_SOURCE_LOCATION (value),
"static member %qD cannot be a bit-field", value);
return NULL_TREE;
}

7
gcc/testsuite/ChangeLog
View file

@ -1,3 +1,10 @@
2018-12-07 Paolo Carlini <paolo.carlini@oracle.com>
* g++.dg/other/bitfield7.C: New.
* g++.dg/parse/bitfield8.C: Likewise.
* g++.dg/parse/bitfield9.C: Likewise.
* g++.dg/pr53037-4.C: Test the locations too.
2018-12-07 Peter Bergner <bergner@linux.ibm.com>
PR target/87496

7
gcc/testsuite/g++.dg/other/bitfield7.C Normal file
View file

@ -0,0 +1,7 @@
typedef int __attribute__((warn_if_not_aligned(8))) intwna;
struct S
{
intwna : 2; // { dg-error "cannot declare bit-field" }
intwna i : 2; // { dg-error "10:cannot declare bit-field .i." }
};

4
gcc/testsuite/g++.dg/parse/bitfield8.C Normal file
View file

@ -0,0 +1,4 @@
struct A
{
static int a : 1; // { dg-error "14:static member .a. cannot be a bit-field" }
};

6
gcc/testsuite/g++.dg/parse/bitfield9.C Normal file
View file

@ -0,0 +1,6 @@
template<typename T>
struct A
{
typedef T type();
type i : 2; // { dg-error "8:cannot declare bit-field" }
};

4
gcc/testsuite/g++.dg/pr53037-4.C
View file

@ -12,7 +12,7 @@ foo2 (void) /* { dg-error "'warn_if_not_aligned' may not be specified for 'void
struct foo3
{
int i : 2 __attribute__((warn_if_not_aligned(8))); /* { dg-error "'warn_if_not_aligned' may not be specified for 'i'" } */
int i : 2 __attribute__((warn_if_not_aligned(8))); /* { dg-error "7:'warn_if_not_aligned' may not be specified for 'i'" } */
};
typedef unsigned int __u32
@ -20,5 +20,5 @@ typedef unsigned int __u32
struct foo4
{
__u32 i : 2; /* { dg-error "cannot declare bit-field 'i' with 'warn_if_not_aligned' type" } */
__u32 i : 2; /* { dg-error "9:cannot declare bit-field 'i' with 'warn_if_not_aligned' type" } */
};