procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

c++: Fix ICE due to folding a call to constructor on cdtor_returns_this arches (aka arm32) [PR113083]

Browse source 
When targetm.cxx.cdtor_returns_this () (aka on arm32 TARGET_AAPCS_BASED)
constructor is supposed to return this pointer, but when we cp_fold such
a call, we don't take that into account and just INIT_EXPR the object,
so we can later ICE during gimplification, because the expression doesn't
have the right type.

2024-02-23  Jakub Jelinek  <jakub@redhat.com>

	PR c++/113083
	* cp-gimplify.cc (cp_fold): For targetm.cxx.cdtor_returns_this ()
	wrap r into a COMPOUND_EXPR and return folded CALL_EXPR_ARG (x, 0).

	* g++.dg/cpp0x/constexpr-113083.C: New test.
This commit is contained in:
Jakub Jelinek 2024-02-23 18:55:12 +01:00
parent ff442719cd
commit fdf9df9d55
2 changed files with 24 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
gcc/cp/cp-gimplify.cc
View file

@ -3412,9 +3412,15 @@ cp_fold (tree x, fold_flags_t flags)
if (DECL_CONSTRUCTOR_P (callee))
{
loc = EXPR_LOCATION (x);
tree s = build_fold_indirect_ref_loc (loc,
CALL_EXPR_ARG (x, 0));
tree a = CALL_EXPR_ARG (x, 0);
bool return_this = targetm.cxx.cdtor_returns_this ();
if (return_this)
a = cp_save_expr (a);
tree s = build_fold_indirect_ref_loc (loc, a);
r = cp_build_init_expr (s, r);
if (return_this)
r = build2_loc (loc, COMPOUND_EXPR, TREE_TYPE (x), r,
fold_convert_loc (loc, TREE_TYPE (x), a));
}
x = r;
break;

16
gcc/testsuite/g++.dg/cpp0x/constexpr-113083.C Normal file
View file

@ -0,0 +1,16 @@
// PR c++/113083
// { dg-do compile { target c++11 } }
// { dg-options "-Os" }
struct A { constexpr A (); };
void
foo ()
{
A b;
}
constexpr
A::A ()
{
}