procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[omp, ftracer] Remove incorrect suggestion in ignore_bb_p

Browse source 
In commit ab3f4b27ab "[omp, ftracer] Don't duplicate blocks in SIMT region" I
added a comment in ignore_bb_p suggesting a reordering of SIMT_VOTE_ANY and
SIMT_EXIT, which is not possible since VOTE_ANY may have data dependencies to
storage that is deallocated by SIMT_EXIT.

I've now opened a PR (PR97291) to describe the problem the reordering was
intended to fix.

Remove the incorrect suggestion.

gcc/ChangeLog:

2020-10-05  Tom de Vries  <tdevries@suse.de>

	* tracer.c (ignore_bb_p): Remove incorrect suggestion.
This commit is contained in:
Tom de Vries 2020-10-05 14:03:34 +02:00
parent f33a43f9f7
commit fc998c21c2
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gcc/tracer.c
View file

@ -115,10 +115,8 @@ ignore_bb_p (const_basic_block bb)
/* An IFN_GOMP_SIMT_ENTER_ALLOC/IFN_GOMP_SIMT_EXIT call must be
duplicated as part of its group, or not at all.
The IFN_GOMP_SIMT_VOTE_ANY is currently part of such a group,
so the same holds there, but it could be argued that the
IFN_GOMP_SIMT_VOTE_ANY could be generated after that group,
in which case it could be duplicated. */
The IFN_GOMP_SIMT_VOTE_ANY is part of such a group, so the same holds
there. */
if (is_gimple_call (g)
&& (gimple_call_internal_p (g, IFN_GOMP_SIMT_ENTER_ALLOC)
|| gimple_call_internal_p (g, IFN_GOMP_SIMT_EXIT)