procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

re PR libgomp/51376 (libgomp taskwait failure)

Browse source 
PR libgomp/51376
	* task.c (GOMP_taskwait): Don't access task->children outside of
	task_lock mutex region.
	(GOMP_task): Likewise.

From-SVN: r182151
This commit is contained in:
Alan Modra 2011-12-09 12:51:43 +10:30 • committed by Alan Modra
parent 108ba412c4
commit fbf7be801c
2 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
libgomp/ChangeLog
View file

@ -1,3 +1,10 @@
2011-12-09 Alan Modra <amodra@gmail.com>
PR libgomp/51376
* task.c (GOMP_taskwait): Don't access task->children outside of
task_lock mutex region.
(GOMP_task): Likewise.
2011-12-06 Jakub Jelinek <jakub@redhat.com>
PR libgomp/51132

8
libgomp/task.c
View file

@ -116,10 +116,11 @@ GOMP_task (void (*fn) (void *), void *data, void (*cpyfn) (void *, void *),
}
else
fn (data);
if (task.children)
if (team != NULL)
{
gomp_mutex_lock (&team->task_lock);
gomp_clear_parent (task.children);
if (task.children != NULL)
gomp_clear_parent (task.children);
gomp_mutex_unlock (&team->task_lock);
}
gomp_end_task ();
@ -290,8 +291,9 @@ GOMP_taskwait (void)
struct gomp_task *child_task = NULL;
struct gomp_task *to_free = NULL;
if (task == NULL || task->children == NULL)
if (task == NULL || team == NULL)
return;
gomp_mutex_lock (&team->task_lock);
while (1)
{