procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

m68k: Quiet up cppcheck warning [PR114689]

Browse source 
cppcheck apparently warns on the | !!sticky part of the expression and
using | (!!sticky) quiets it up (it is correct as is).
The following patch adds the ()s, and also adds them around mant >> 1 just
in case it makes it clearer to all readers that the expression is parsed
that way already.

2024-04-15  Jakub Jelinek  <jakub@redhat.com>

	PR libgcc/114689
	* config/m68k/fpgnulib.c (__truncdfsf2): Add parentheses around
	!!sticky bitwise or operand to quiet up cppcheck.  Add parentheses
	around mant >> 1 bitwise or operand.
This commit is contained in:
Jakub Jelinek 2024-04-15 17:46:03 +02:00
parent 52972ab5c7
commit f8409c3109
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libgcc/config/m68k/fpgnulib.c
View file

@ -302,7 +302,7 @@ __truncdfsf2 (double a1)
if (exp == EXPDMASK - EXCESSD + EXCESS)
{
exp = EXPMASK;
mant = mant >> 1 | (mant & 1) | !!sticky;
mant = (mant >> 1) | (mant & 1) | (!!sticky);
}
else
{