diff --git a/gcc/cp/typeck.cc b/gcc/cp/typeck.cc index 439681216be..4c15e26f692 100644 --- a/gcc/cp/typeck.cc +++ b/gcc/cp/typeck.cc @@ -11239,6 +11239,8 @@ check_return_expr (tree retval, bool *no_warning, bool *dangling) "function returning %qT", valtype); /* Remember that this function did return. */ current_function_returns_value = 1; + /* But suppress NRV .*/ + current_function_return_value = error_mark_node; /* And signal caller that TREE_NO_WARNING should be set on the RETURN_EXPR to avoid control reaches end of non-void function warnings in tree-cfg.cc. */ @@ -11449,7 +11451,11 @@ check_return_expr (tree retval, bool *no_warning, bool *dangling) /* If the conversion failed, treat this just like `return;'. */ if (retval == error_mark_node) - return retval; + { + /* And suppress NRV. */ + current_function_return_value = error_mark_node; + return retval; + } /* We can't initialize a register from a AGGR_INIT_EXPR. */ else if (! cfun->returns_struct && TREE_CODE (retval) == TARGET_EXPR diff --git a/gcc/testsuite/g++.dg/parse/crash78.C b/gcc/testsuite/g++.dg/parse/crash78.C new file mode 100644 index 00000000000..f30fe08df54 --- /dev/null +++ b/gcc/testsuite/g++.dg/parse/crash78.C @@ -0,0 +1,15 @@ +// PR c++/117099 +// { dg-do "compile" } + +struct X { + ~X(); +}; + +X test(bool b) { + { + X x; + return x; + } + return X(); + if (!(b)) return; // { dg-error "return-statement with no value" } +} diff --git a/gcc/testsuite/g++.dg/parse/crash78a.C b/gcc/testsuite/g++.dg/parse/crash78a.C new file mode 100644 index 00000000000..241a5e390de --- /dev/null +++ b/gcc/testsuite/g++.dg/parse/crash78a.C @@ -0,0 +1,22 @@ +// PR c++/117099 +// With -fpermissive, make sure we don't do NRV in this case, but keep +// executing fine. Note that the return at line 16 is undefined behaviour. +// { dg-do "run" } +// { dg-options "-fpermissive" } + +struct X { + ~X() {} +}; + +X test(bool b) { + X x; + if (b) + return x; + else + return; // { dg-warning "return-statement with no value" } +} + +int main(int, char*[]) { + (void) test (false); + return 0; +} diff --git a/gcc/testsuite/g++.dg/parse/crash79.C b/gcc/testsuite/g++.dg/parse/crash79.C new file mode 100644 index 00000000000..08d62af39c6 --- /dev/null +++ b/gcc/testsuite/g++.dg/parse/crash79.C @@ -0,0 +1,15 @@ +// PR c++/117129 +// { dg-do "compile" { target c++11 } } + +struct Noncopyable { + Noncopyable(); + Noncopyable(const Noncopyable &) = delete; // { dg-note "declared here" } + virtual ~Noncopyable(); +}; +Noncopyable nrvo() { + { + Noncopyable A; + return A; // { dg-error "use of deleted function" } + // { dg-note "display considered" "" { target *-*-* } .-1 } + } +}