procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

sarif-replay: fix missing URLs [PR117944]

Browse source 
gcc/ChangeLog:
	PR other/117944
	* libsarifreplay.cc (sarif_replayer::handle_result_obj): Get any
	helpUri	from the rule_obj and pass it to add_rule.

Signed-off-by: David Malcolm <dmalcolm@redhat.com>
This commit is contained in:
David Malcolm 2024-12-10 18:31:24 -05:00
parent 5fba71a88f
commit f102b82d3d
1 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
gcc/libsarifreplay.cc
View file

@ -1004,7 +1004,20 @@ sarif_replayer::handle_result_obj (const json::object &result_obj,
libgdiagnostics::group g (m_output_mgr);
auto err (m_output_mgr.begin_diagnostic (level));
if (rule_id)
err.add_rule (rule_id->get_string (), nullptr);
{
const char *url = nullptr;
if (rule_obj)
{
/* rule_obj should be a reportingDescriptor object (3.49).
Get any §3.49.12 helpUri property. */
const property_spec_ref prop_help_uri
("reportingDescriptor", "helpUri", "3.49.12");
if (auto url_val = get_optional_property<json::string>(*rule_obj,
prop_help_uri))
url = url_val->get_string ();
}
err.add_rule (rule_id->get_string (), url);
}
err.set_location (physical_loc);
err.set_logical_location (logical_loc);
if (path.m_inner)