procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

libstdc++: testsuite: skip fs last_write_time tests if dummy

Browse source 
The last_write_time functions are defined in ways that are useful, or
that fail immediately, depending on various macros.  When they fail
immediately, the filesystem last_write_time.cc tests fail noisily, but
the fail is entirely expected.

Define NO_LAST_WRITE_TIME in the last_write_time.cc tests, according
to the macros that select implementations of last_write_time, and use
it through the new dg-require-target-fs-lwt to skip tests that are
expected to fail.


for  libstdc++-v3/ChangeLog

	* testsuite/util/testsuite_fs.h (NO_LAST_WRITE_TIME): Define
	when appropriate.
	* testsuite/lib/libstdc++.exp
	(check_v3_target_fs_last_write_time): New.
	* testsuite/lib/dg-options.exp (dg-require-target-fs-lwt):
	New.
	* testsuite/27_io/filesystem/operations/last_write_time.cc:
	Skip the test if the features are unavailable.
	* testsuite/experimental/filesystem/operations/last_write_time.cc:
	Likewise.
This commit is contained in:
Alexandre Oliva 2022-06-23 23:20:51 -03:00 • committed by Alexandre Oliva
parent b931c6874e
commit f01cf5eaa0
5 changed files with 24 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
libstdc++-v3/testsuite/27_io/filesystem/operations/last_write_time.cc
View file

@ -17,6 +17,7 @@
// { dg-do run { target c++17 } }
// { dg-require-filesystem-ts "" }
// { dg-require-target-fs-lwt "" }
// 15.25 Permissions [fs.op.last_write_time]

1
libstdc++-v3/testsuite/experimental/filesystem/operations/last_write_time.cc
View file

@ -18,6 +18,7 @@
// { dg-options "-DUSE_FILESYSTEM_TS -lstdc++fs" }
// { dg-do run { target c++11 } }
// { dg-require-filesystem-ts "" }
// { dg-require-target-fs-lwt "" }
// 15.25 Permissions [fs.op.last_write_time]

9
libstdc++-v3/testsuite/lib/dg-options.exp
View file

@ -259,6 +259,15 @@ proc dg-require-target-fs-space { args } {
return
}
proc dg-require-target-fs-lwt { args } {
if { ![ check_v3_target_fs_last_write_time ] } {
upvar dg-do-what dg-do-what
set dg-do-what [list [lindex ${dg-do-what} 0] "N" "P"]
return
}
return
}
proc add_options_for_no_pch { flags } {
# This forces any generated and possibly included PCH to be invalid.
return "-D__GLIBCXX__=99999999"

8
libstdc++-v3/testsuite/lib/libstdc++.exp
View file

@ -1286,6 +1286,14 @@ proc check_v3_target_fs_space { } {
return [v3_check_preprocessor_condition fs_space $cond $inc]
}
# Return 1 if the libstdc++ filesystem implementation of
# last_write_time is not an always-failing dummy.
proc check_v3_target_fs_last_write_time { } {
set inc "#include <testsuite_fs.h>"
set cond "!defined NO_LAST_WRITE_TIME"
return [v3_check_preprocessor_condition fs_last_write_time $cond $inc]
}
# Return 1 if the "cxx11" ABI is in use using the current flags, 0 otherwise.
# Any flags provided by RUNTESTFLAGS or a target board will be used here.
# Flags added in the test by dg-options or dg-add-options will not be used.

5
libstdc++-v3/testsuite/util/testsuite_fs.h
View file

@ -51,6 +51,11 @@ namespace test_fs = std::experimental::filesystem;
#define NO_SPACE
#endif
#if !(_GLIBCXX_HAVE_SYS_STAT_H \
&& (_GLIBCXX_USE_UTIMENSAT || _GLIBCXX_USE_UTIME))
#define NO_LAST_WRITE_TIME 1
#endif
namespace __gnu_test
{
#define PATH_CHK(p1, p2, fn) \