procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

re PR middle-end/57134 (ICE with -mstrict-align and inline assembly on ppc64)

Browse source 
PR middle-end/57134
	PR middle-end/57586
	* expr.c (expand_expr_real_1 <normal_inner_ref>): Pass
	EXPAND_MEMORY and EXPAND_WRITE to recursive call.  Don't use
	bitfield expansion when EXPAND_MEMORY.
	(expand_expr_real_1 <VIEW_CONVERT_EXPR>): Pass modifier likewise.

	* gcc.dg/pr57134.c: New.

From-SVN: r200086
This commit is contained in:
Alan Modra 2013-06-14 18:07:30 +09:30 • committed by Alan Modra
parent 48f316eafe
commit ef7e7ab278
4 changed files with 46 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
gcc/ChangeLog
View file

@ -1,3 +1,12 @@
2013-06-14 Alan Modra <amodra@gmail.com>
PR middle-end/57134
PR middle-end/57586
* expr.c (expand_expr_real_1 <normal_inner_ref>): Pass
EXPAND_MEMORY and EXPAND_WRITE to recursive call. Don't use
bitfield expansion when EXPAND_MEMORY.
(expand_expr_real_1 <VIEW_CONVERT_EXPR>): Pass modifier likewise.
2013-06-13 Michael Meissner <meissner@linux.vnet.ibm.com>
* config/rs6000/rs6000.c (rs6000_option_override_internal): Move

12
gcc/expr.c
View file

@ -9909,11 +9909,7 @@ expand_expr_real_1 (tree exp, rtx target, enum machine_mode tmode,
&& modifier != EXPAND_STACK_PARM
? target : NULL_RTX),
VOIDmode,
(modifier == EXPAND_INITIALIZER
|| modifier == EXPAND_CONST_ADDRESS
|| modifier == EXPAND_STACK_PARM)
? modifier : EXPAND_NORMAL);
modifier == EXPAND_SUM ? EXPAND_NORMAL : modifier);
/* If the bitfield is volatile, we want to access it in the
field's mode, not the computed mode.
@ -10072,6 +10068,7 @@ expand_expr_real_1 (tree exp, rtx target, enum machine_mode tmode,
|| (MEM_P (op0)
&& (MEM_ALIGN (op0) < GET_MODE_ALIGNMENT (mode1)
|| (bitpos % GET_MODE_ALIGNMENT (mode1) != 0))))
&& modifier != EXPAND_MEMORY
&& ((modifier == EXPAND_CONST_ADDRESS
|| modifier == EXPAND_INITIALIZER)
? STRICT_ALIGNMENT
@ -10271,10 +10268,7 @@ expand_expr_real_1 (tree exp, rtx target, enum machine_mode tmode,
&& modifier != EXPAND_STACK_PARM
? target : NULL_RTX),
VOIDmode,
(modifier == EXPAND_INITIALIZER
|| modifier == EXPAND_CONST_ADDRESS
|| modifier == EXPAND_STACK_PARM)
? modifier : EXPAND_NORMAL);
modifier == EXPAND_SUM ? EXPAND_NORMAL : modifier);
if (MEM_P (orig_op0))
{

5
gcc/testsuite/ChangeLog
View file

@ -1,3 +1,8 @@
2013-06-14 Alan Modra <amodra@gmail.com>
PR middle-end/57134
* gcc.dg/pr57134.c: New.
2013-06-14 Tobias Burnus <burnus@net-b.de>
PR fortran/57596

29
gcc/testsuite/gcc.dg/pr57134.c Normal file
View file

@ -0,0 +1,29 @@
/* { dg-do compile } */
/* { dg-require-effective-target stdint_types } */
/* { dg-options "-O2" } */
/* { dg-options "-O2 -mstrict-align" { target { powerpc*-*-linux* powerpc*-*-elf* } } } */
#include <stdint.h>
typedef struct {
int64_t counter;
} atomic64_t;
struct buffer_page {
void *a, *b;
atomic64_t entries;
};
static __inline__ __attribute__((always_inline)) int64_t
atomic64_read(const atomic64_t *v)
{
int64_t t;
__asm__ __volatile__("# %0, %1" : "=r"(t) : "m"(v->counter));
return t;
}
int rb_remove_pages(void *p)
{
struct buffer_page *blah = (void *)((intptr_t) p & -4);
return atomic64_read(&blah->entries);
}