procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Ada] Fix warning about generic subprograms withed but not referenced

Browse source 
For warnings about unreferenced entities and unused WITH clauses we
typically exclude references outside of the extended main source unit.
However, we include references to variables of formal private types to
warn in the instance if the corresponding type is not a fully
initialized type.

This special case was unnecessarily applied to references to other
entities of formal private types. In particular, we applied it to the
references to generic functions, where the full initialization of the
formal private type doesn't matter.

As an extreme example, this special case was unnecessarily applied to
"pragma Pure (Unchecked_Conversion)" in the runtime unit.

gcc/ada/

	* lib-xref.adb (Generate_Reference): Fix comment and implement
	it precisely.
This commit is contained in:
Piotr Trojanek 2022-02-11 14:31:39 +01:00 • committed by Pierre-Marie de Rodat
parent 3707c8feb1
commit ec0f9f7d88
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
gcc/ada/lib-xref.adb
View file

@ -664,7 +664,7 @@ package body Lib.Xref is
-- a default in an instance.
-- We also set the referenced flag in a generic package that is not in
-- then main source unit, when the variable is of a formal private type,
-- the main source unit, when the object is of a formal private type,
-- to warn in the instance if the corresponding type is not a fully
-- initialized type.
@ -694,6 +694,7 @@ package body Lib.Xref is
return;
elsif Inside_A_Generic
and then Is_Object (E)
and then Is_Generic_Type (Etype (E))
then
Set_Referenced (E);