procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove recursive post-dominator traversal in sinking

Browse source 
The following turns the recursive post-dominator traversal in GIMPLE
code sinking to a worklist.

	* tree-ssa-sink.cc (sink_code_in_bb): Remove recursion, instead
	use a worklist ...
	(pass_sink_code::execute): ... in the caller.
This commit is contained in:
Richard Biener 2023-07-27 10:23:16 +02:00
parent ca912a39cc
commit e7cda6ef77
1 changed files with 16 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
gcc/tree-ssa-sink.cc
View file

@ -671,7 +671,6 @@ sink_common_stores_to_bb (basic_block bb)
static unsigned
sink_code_in_bb (basic_block bb)
{
basic_block son;
gimple_stmt_iterator gsi;
edge_iterator ei;
edge e;
@ -684,12 +683,12 @@ sink_code_in_bb (basic_block bb)
/* If this block doesn't dominate anything, there can't be any place to sink
the statements to. */
if (first_dom_son (CDI_DOMINATORS, bb) == NULL)
goto earlyout;
return todo;
/* We can't move things across abnormal edges, so don't try. */
FOR_EACH_EDGE (e, ei, bb->succs)
if (e->flags & EDGE_ABNORMAL)
goto earlyout;
return todo;
for (gsi = gsi_last_bb (bb); !gsi_end_p (gsi);)
{
@ -763,13 +762,6 @@ sink_code_in_bb (basic_block bb)
gsi_prev (&gsi);
}
earlyout:
for (son = first_dom_son (CDI_POST_DOMINATORS, bb);
son;
son = next_dom_son (CDI_POST_DOMINATORS, son))
{
todo |= sink_code_in_bb (son);
}
return todo;
}
@ -859,7 +851,20 @@ pass_sink_code::execute (function *fun)
memset (&sink_stats, 0, sizeof (sink_stats));
calculate_dominance_info (CDI_DOMINATORS);
calculate_dominance_info (CDI_POST_DOMINATORS);
todo |= sink_code_in_bb (EXIT_BLOCK_PTR_FOR_FN (fun));
auto_vec<basic_block, 64> worklist;
worklist.quick_push (EXIT_BLOCK_PTR_FOR_FN (fun));
do
{
basic_block bb = worklist.pop ();
todo |= sink_code_in_bb (bb);
for (basic_block son = first_dom_son (CDI_POST_DOMINATORS, bb);
son;
son = next_dom_son (CDI_POST_DOMINATORS, son))
worklist.safe_push (son);
}
while (!worklist.is_empty ());
statistics_counter_event (fun, "Sunk statements", sink_stats.sunk);
statistics_counter_event (fun, "Commoned stores", sink_stats.commoned);
free_dominance_info (CDI_POST_DOMINATORS);