procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix ICE in pass_rpad.

Browse source 
Besides conversion instructions, pass_rpad also handles scalar
sqrt/rsqrt/rcp/round instructions, while r12-3614 should only want to
handle conversion instructions, so fix it.

gcc/ChangeLog:

	* config/i386/i386-features.c (remove_partial_avx_dependency):
	Restrict TARGET_USE_VECTOR_FP_CONVERTS and
	TARGET_USE_VECTOR_CONVERTS to conversion instructions only.
This commit is contained in:
liuhongt 2021-09-18 10:49:54 +08:00
parent e5597f2ad5
commit e666a0a22a
1 changed files with 22 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
gcc/config/i386/i386-features.c
View file

@ -2165,7 +2165,7 @@ make_pass_insert_endbr_and_patchable_area (gcc::context *ctxt)
}
/* At entry of the nearest common dominator for basic blocks with
conversions, generate a single
conversions/rcp/sqrt/rsqrt/round, generate a single
vxorps %xmmN, %xmmN, %xmmN
for all
vcvtss2sd op, %xmmN, %xmmX
@ -2211,13 +2211,27 @@ remove_partial_avx_dependency (void)
continue;
/* Convert PARTIAL_XMM_UPDATE_TRUE insns, DF -> SF, SF -> DF,
SI -> SF, SI -> DF, DI -> SF, DI -> DF, to vec_dup and
vec_merge with subreg. */
SI -> SF, SI -> DF, DI -> SF, DI -> DF, sqrt, rsqrt, rcp,
round, to vec_dup and vec_merge with subreg. */
rtx src = SET_SRC (set);
rtx dest = SET_DEST (set);
machine_mode dest_mode = GET_MODE (dest);
machine_mode src_mode = GET_MODE (XEXP (src, 0));
bool convert_p = false;
switch (GET_CODE (src))
{
case FLOAT:
case FLOAT_EXTEND:
case FLOAT_TRUNCATE:
case UNSIGNED_FLOAT:
convert_p = true;
break;
default:
break;
}
/* Only hanlde conversion here. */
machine_mode src_mode
= convert_p ? GET_MODE (XEXP (src, 0)) : VOIDmode;
switch (src_mode)
{
case E_SFmode:
@ -2232,8 +2246,11 @@ remove_partial_avx_dependency (void)
|| !TARGET_SSE_PARTIAL_REG_CONVERTS_DEPENDENCY)
continue;
break;
default:
case E_VOIDmode:
gcc_assert (!convert_p);
break;
default:
gcc_unreachable ();
}
if (!v4sf_const0)