procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

re PR c/48985 (bogus buffer overflow warning and abort on static flexible array member)

Browse source 
2011-05-19  Richard Guenther  <rguenther@suse.de>

	PR middle-end/48985
	* tree-object-size.c (addr_object_size): If the pointed-to
	variable is a decl use DECL_SIZE_UNIT instead of TYPE_SIZE_UNIT.

	* gcc.dg/builtin-object-size-11.c: New testcase.

From-SVN: r173901
This commit is contained in:
Richard Guenther 2011-05-19 10:45:26 +00:00 • committed by Richard Biener
parent 31b3ca64f4
commit e497b9bd88
4 changed files with 37 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gcc/ChangeLog
View file

@ -1,3 +1,9 @@
2011-05-19 Richard Guenther <rguenther@suse.de>
PR middle-end/48985
* tree-object-size.c (addr_object_size): If the pointed-to
variable is a decl use DECL_SIZE_UNIT instead of TYPE_SIZE_UNIT.
2011-05-19 Richard Guenther <rguenther@suse.de>
* gimple.c (gimple_types_compatible_p_1): Compare names of

5
gcc/testsuite/ChangeLog
View file

@ -1,3 +1,8 @@
2011-05-19 Richard Guenther <rguenther@suse.de>
PR middle-end/48985
* gcc.dg/builtin-object-size-11.c: New testcase.
2011-05-19 Tom de Vries <tom@codesourcery.com>
PR target/45098

20
gcc/testsuite/gcc.dg/builtin-object-size-11.c Normal file
View file

@ -0,0 +1,20 @@
/* PR48985 */
/* { dg-do run } */
extern void abort (void);
struct s {
int i;
char c[];
} s = { 1, "01234" };
__SIZE_TYPE__ f (void) { return __builtin_object_size (&s.c, 0); }
int
main()
{
if (f() != sizeof ("01234"))
abort ();
return 0;
}

6
gcc/tree-object-size.c
View file

@ -204,6 +204,12 @@ addr_object_size (struct object_size_info *osi, const_tree ptr,
if (sz != unknown[object_size_type] && sz < offset_limit)
pt_var_size = size_int (sz);
}
else if (pt_var
&& DECL_P (pt_var)
&& host_integerp (DECL_SIZE_UNIT (pt_var), 1)
&& (unsigned HOST_WIDE_INT)
tree_low_cst (DECL_SIZE_UNIT (pt_var), 1) < offset_limit)
pt_var_size = DECL_SIZE_UNIT (pt_var);
else if (pt_var
&& (SSA_VAR_P (pt_var) || TREE_CODE (pt_var) == STRING_CST)
&& TYPE_SIZE_UNIT (TREE_TYPE (pt_var))