From e2c42860b6bad30bad8dd12fd0e25dc55646a69c Mon Sep 17 00:00:00 2001 From: David Faust Date: Mon, 21 Aug 2023 13:34:08 -0700 Subject: [PATCH] bpf: neg instruction does not accept an immediate The BPF virtual machine does not support neg nor neg32 instructions with an immediate. The erroneous instructions were removed from binutils: https://sourceware.org/pipermail/binutils/2023-August/129135.html Change the define_insn so that an immediate cannot be accepted. From testing, a neg-immediate was probably never chosen over a mov-immediate anyway. gcc/ * config/bpf/bpf.md (neg): Second operand must be a register. --- gcc/config/bpf/bpf.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/config/bpf/bpf.md b/gcc/config/bpf/bpf.md index a64de1095ed..e87d72182bb 100644 --- a/gcc/config/bpf/bpf.md +++ b/gcc/config/bpf/bpf.md @@ -163,8 +163,8 @@ ;;; Negation (define_insn "neg2" - [(set (match_operand:AM 0 "register_operand" "=r,r") - (neg:AM (match_operand:AM 1 "reg_or_imm_operand" " 0,I")))] + [(set (match_operand:AM 0 "register_operand" "=r") + (neg:AM (match_operand:AM 1 "register_operand" " 0")))] "" "{neg\t%0|%w0 = -%w1}" [(set_attr "type" "")])