From e1ff19bf801a69ab7ae22ccb2ebd5842d6432a1c Mon Sep 17 00:00:00 2001 From: Ben Elliston Date: Thu, 9 Apr 2009 21:26:44 +0000 Subject: [PATCH] re PR target/36800 (va_arg for _Decimal128 on 32-bit Power mishandled in certain cases) PR target/36800 PR target/36800 * config/rs6000/rs6000.c (rs6000_gimplify_va_arg): Do not set regalign for the reg == fpr and TDmode case. testsuite/ * gcc.dg/dfp/pr36800.c: New. Co-Authored-By: Joseph Myers From-SVN: r145859 --- gcc/ChangeLog | 6 ++++++ gcc/config/rs6000/rs6000.c | 1 - gcc/testsuite/ChangeLog | 6 ++++++ gcc/testsuite/gcc.dg/dfp/pr36800.c | 32 ++++++++++++++++++++++++++++++ 4 files changed, 44 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/dfp/pr36800.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 5e51f8510bb..3efe49a5748 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2009-04-10 Ben Elliston + + PR target/36800 + * config/rs6000/rs6000.c (rs6000_gimplify_va_arg): Do not set + regalign for the reg == fpr and TDmode case. + 2009-04-09 David Ayers PR objc/29200 diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c index 07fa33e3f1a..235298935c3 100644 --- a/gcc/config/rs6000/rs6000.c +++ b/gcc/config/rs6000/rs6000.c @@ -7092,7 +7092,6 @@ rs6000_gimplify_va_arg (tree valist, tree type, gimple_seq *pre_p, reg number is 0 for f1, so we want to make it odd. */ else if (reg == fpr && TYPE_MODE (type) == TDmode) { - regalign = 1; t = build2 (BIT_IOR_EXPR, TREE_TYPE (reg), unshare_expr (reg), build_int_cst (TREE_TYPE (reg), 1)); u = build2 (MODIFY_EXPR, void_type_node, unshare_expr (reg), t); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 01a21a47b85..c346b6129da 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2009-04-10 Ben Elliston + Joseph Myers + + PR target/36800 + * gcc.dg/dfp/pr36800.c: New. + 2009-04-09 Ralf Wildenhues Rafael Avila de Espindola diff --git a/gcc/testsuite/gcc.dg/dfp/pr36800.c b/gcc/testsuite/gcc.dg/dfp/pr36800.c new file mode 100644 index 00000000000..5b899cf0e7f --- /dev/null +++ b/gcc/testsuite/gcc.dg/dfp/pr36800.c @@ -0,0 +1,32 @@ +/* { dg-do run } */ +/* { dg-options "-std=gnu99" } */ + +#include +extern void abort (void); + +void +f (int a, ...) +{ + va_list ap; + if (a != 0) + abort (); + va_start (ap, a); + if (va_arg (ap, _Decimal128) != 1.2DL) + abort (); + if (va_arg (ap, _Decimal128) != 2.34DL) + abort (); + if (va_arg (ap, _Decimal128) != 3.456DL) + abort (); + if (va_arg (ap, _Decimal128) != 4.567DL) + abort (); + if (va_arg (ap, double) != 5.125) + abort (); + va_end (ap); +} + +int +main (void) +{ + f (0, 1.2DL, 2.34DL, 3.456DL, 4.567DL, 5.125); + return 0; +}