From dde75838e94cc9b22bc6210802b1849b2ae3f3cf Mon Sep 17 00:00:00 2001 From: Joseph Myers Date: Thu, 28 Feb 2008 12:34:51 +0000 Subject: [PATCH] re PR target/33963 (Dllimport attribute wrongly accepted on typedefs) PR target/33963 * tree.c (handle_dll_attribute): Disallow TYPE_DECLs for types other than structures and unions. From-SVN: r132744 --- gcc/ChangeLog | 6 ++++++ gcc/tree.c | 10 ++++++++++ 2 files changed, 16 insertions(+) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 4d168e35b2f..a0663ff0d3a 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2008-02-28 Joseph Myers + + PR target/33963 + * tree.c (handle_dll_attribute): Disallow TYPE_DECLs for types + other than structures and unions. + 2008-02-28 Richard Guenther Revert: diff --git a/gcc/tree.c b/gcc/tree.c index 85b0b1c11c6..c39bccda098 100644 --- a/gcc/tree.c +++ b/gcc/tree.c @@ -3971,6 +3971,16 @@ handle_dll_attribute (tree * pnode, tree name, tree args, int flags, return NULL_TREE; } + if (TREE_CODE (node) == TYPE_DECL + && TREE_CODE (TREE_TYPE (node)) != RECORD_TYPE + && TREE_CODE (TREE_TYPE (node)) != UNION_TYPE) + { + *no_add_attrs = true; + warning (OPT_Wattributes, "%qs attribute ignored", + IDENTIFIER_POINTER (name)); + return NULL_TREE; + } + /* Report error on dllimport ambiguities seen now before they cause any damage. */ else if (is_attribute_p ("dllimport", name))