procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix PR 111259 invalid zcmp mov predicate.

Browse source 
The code changes are from Palmer.

root cause:
In a gcc build with --enable-checking=yes, REGNO (op) checks
rtx code and expected code 'reg'. so a rtx with 'subreg' causes
an internal compiler error.

solution:
Restrict predicate to allow 'reg' only.

gcc/ChangeLog:

	* config/riscv/predicates.md: Restrict predicate
	to allow 'reg' only.
Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
This commit is contained in:
Fei Gao 2023-09-15 01:20:08 +00:00 • committed by Patrick O'Neill
parent fd5a858eb5
commit d7b6020276
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gcc/config/riscv/predicates.md
View file

@ -74,6 +74,7 @@
(ior (match_operand 0 "const_0_operand")
(match_operand 0 "register_operand")))
;; ZCMP predicates
(define_predicate "stack_push_up_to_ra_operand"
(and (match_code "const_int")
(match_test "riscv_zcmp_valid_stack_adj_bytes_p (INTVAL (op) * -1, 1)")))
@ -170,13 +171,12 @@
(and (match_code "const_int")
(match_test "riscv_zcmp_valid_stack_adj_bytes_p (INTVAL (op), 13)")))
;; ZCMP predicates
(define_predicate "a0a1_reg_operand"
(and (match_operand 0 "register_operand")
(and (match_code "reg")
(match_test "IN_RANGE (REGNO (op), A0_REGNUM, A1_REGNUM)")))
(define_predicate "zcmp_mv_sreg_operand"
(and (match_operand 0 "register_operand")
(and (match_code "reg")
(match_test "TARGET_RVE ? IN_RANGE (REGNO (op), S0_REGNUM, S1_REGNUM)
: IN_RANGE (REGNO (op), S0_REGNUM, S1_REGNUM)
|| IN_RANGE (REGNO (op), S2_REGNUM, S7_REGNUM)")))