procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

re PR rtl-optimization/12926 (Wrong value after assignment in initialize list using bit-fields)

Browse source 
PR optimization/12926
	* expr.c (expand_assignment) [COMPONENT_REF]: Don't put
	the UNCHANGING_RTX_P flag on memory references to read-only
	components that are not addressable.

From-SVN: r73542
This commit is contained in:
Eric Botcazou 2003-11-13 10:48:36 +01:00 • committed by Eric Botcazou
parent 239ca41f81
commit d76bc29c91
4 changed files with 60 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gcc/ChangeLog
View file

@ -1,3 +1,10 @@
2003-11-13 Eric Botcazou <ebotcazou@libertysurf.fr>
PR optimization/12926
* expr.c (expand_assignment) [COMPONENT_REF]: Don't put
the UNCHANGING_RTX_P flag on memory references to read-only
components that are not addressable.
2003-11-12 Kazu Hirata <kazu@cs.umass.edu>
* config/h8300/lib1funcs.asm (divmodsi4): Clear S0P in

6
gcc/expr.c
View file

@ -3826,7 +3826,11 @@ expand_assignment (tree to, tree from, int want_value)
}
if (TREE_CODE (to) == COMPONENT_REF
&& TREE_READONLY (TREE_OPERAND (to, 1)))
&& TREE_READONLY (TREE_OPERAND (to, 1))
/* We can't assert that a MEM won't be set more than once
if the component is not addressable because another
non-addressable component may be referenced by the same MEM. */
&& ! (GET_CODE (to_rtx) == MEM && ! can_address_p (to)))
{
if (to_rtx == orig_to_rtx)
to_rtx = copy_rtx (to_rtx);

4
gcc/testsuite/ChangeLog
View file

@ -1,3 +1,7 @@
2003-11-13 Eric Botcazou <ebotcazou@libertysurf.fr>
* g++.dg/opt/const3.C: New test.
2003-11-13 Jan Hubicka <jh@suse.cz>
* gcc.c-torture/compile/20031112-1.c: New test.

44
gcc/testsuite/g++.dg/opt/const3.C Normal file
View file

@ -0,0 +1,44 @@
// PR optimization/12926
// This failed on SPARC64 because the assignments to the bit-fields
// were wrongly swapped in the constructor.
// { dg-do run }
// { dg-options "-O2" }
extern void abort(void);
typedef __SIZE_TYPE__ size_t;
void *my_out;
struct A
{
enum Type {P, U, S};
int foo1(void *, const char *);
int foo2(int, const Type);
A (const size_t size, const Type type): mSize(size), mType(type)
{
foo2(foo1(my_out, "type = "), type);
foo2(foo1(my_out, "mType = "), mType);
}
const size_t mSize : 8*sizeof(size_t) - 3;
Type mType : 2;
};
int i;
int A::foo1(void *ios, const char *str) { }
int A::foo2(int v, const Type t) { i=0; }
int main()
{
A testa(2, A::S);
if (testa.mType != A::S)
abort();
return 0;
}