procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

PR c++/77777 improve location for diagnostic

Browse source 
Pass in the location of the invalid expression, not the next input
location (which might be a comma or closing parenthesis on a different
line).

gcc/cp:

	PR c++/77777
	* call.c (resolve_args): Use location of expression, not current input
	location.

gcc/testsuite:

	PR c++/77777
	* g++.dg/diagnostic/pr77777.C: New test.

From-SVN: r260979
This commit is contained in:
Jonathan Wakely 2018-05-31 00:13:48 +01:00 • committed by Jonathan Wakely
parent b67b9225f7
commit d72a3672c5
4 changed files with 28 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gcc/cp/ChangeLog
View file

@ -1,3 +1,9 @@
2018-05-30 Jonathan Wakely <jwakely@redhat.com>
PR c++/77777
* call.c (resolve_args): Use location of expression, not current input
location.
2018-05-30 Ville Voutilainen <ville.voutilainen@gmail.com>
Do not warn about zero-as-null when NULL is used.

2
gcc/cp/call.c
View file

@ -4147,7 +4147,7 @@ resolve_args (vec<tree, va_gc> *args, tsubst_flags_t complain)
error ("invalid use of void expression");
return NULL;
}
else if (invalid_nonstatic_memfn_p (input_location, arg, complain))
else if (invalid_nonstatic_memfn_p (arg->exp.locus, arg, complain))
return NULL;
}
return args;

5
gcc/testsuite/ChangeLog
View file

@ -1,3 +1,8 @@
2018-05-30 Jonathan Wakely <jwakely@redhat.com>
PR c++/77777
* g++.dg/diagnostic/pr77777.C: New test.
2018-05-30 David Pagan <dave.pagan@oracle.com>
PR c/55976

16
gcc/testsuite/g++.dg/diagnostic/pr77777.C Normal file
View file

@ -0,0 +1,16 @@
// PR c++/77777
// { dg-do compile }
struct X {
int f();
};
void g(int);
int main()
{
X x;
g(
x.f // { dg-error "invalid use of non-static member function" }
);
}