procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

PR rtl-optimization/96692: ((A|B)^C)^A using andn with -mbmi on x86.

Browse source 
This patch addresses PR rtl-optimization/96692 on x86_64, by providing
a set of combine splitters to convert the three operation ((A|B)^C)^D
into a two operation sequence using andn when either A or B is the same
register as C or D.  This is essentially a reassociation problem that's
only a win if the target supports an and-not instruction (as with -mbmi).

Hence for the new test case:

int f(int a, int b, int c)
{
    return (a ^ b) ^ (a | c);
}

GCC on x86_64-pc-linux-gnu wth -O2 -mbmi would previously generate:

        xorl    %edi, %esi
        orl     %edx, %edi
        movl    %esi, %eax
        xorl    %edi, %eax
        ret

but with this patch now generates:

        andn    %edx, %edi, %eax
        xorl    %esi, %eax
        ret

2022-07-05  Roger Sayle  <roger@nextmovesoftware.com>
	    Uroš Bizjak  <ubizjak@gmail.com>

gcc/ChangeLog
	PR rtl-optimization/96692
	* config/i386/i386.md (define_split): Split ((A | B) ^ C) ^ D
	as (X & ~Y) ^ Z on target BMI when either C or D is A or B.

gcc/testsuite/ChangeLog
	PR rtl-optimization/96692
	* gcc.target/i386/bmi-andn-4.c: New test case.
This commit is contained in:
Roger Sayle 2022-07-05 17:55:53 +01:00
parent 069f46c71e
commit d458c53a6f
2 changed files with 85 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

76
gcc/config/i386/i386.md
View file

@ -10522,6 +10522,82 @@
(set (match_dup 0) (match_op_dup 1
[(and:SI (match_dup 3) (match_dup 2))
(const_int 0)]))])
;; Variant 1 of 4: Split ((A | B) ^ A) ^ C as (B & ~A) ^ C.
(define_split
[(set (match_operand:SWI48 0 "register_operand")
(xor:SWI48
(xor:SWI48
(ior:SWI48 (match_operand:SWI48 1 "register_operand")
(match_operand:SWI48 2 "nonimmediate_operand"))
(match_dup 1))
(match_operand:SWI48 3 "nonimmediate_operand")))
(clobber (reg:CC FLAGS_REG))]
"TARGET_BMI"
[(parallel
[(set (match_dup 4) (and:SWI48 (not:SWI48 (match_dup 1)) (match_dup 2)))
(clobber (reg:CC FLAGS_REG))])
(parallel
[(set (match_dup 0) (xor:SWI48 (match_dup 4) (match_dup 3)))
(clobber (reg:CC FLAGS_REG))])]
"operands[4] = gen_reg_rtx (<MODE>mode);")
;; Variant 2 of 4: Split ((A | B) ^ B) ^ C as (A & ~B) ^ C.
(define_split
[(set (match_operand:SWI48 0 "register_operand")
(xor:SWI48
(xor:SWI48
(ior:SWI48 (match_operand:SWI48 1 "register_operand")
(match_operand:SWI48 2 "register_operand"))
(match_dup 2))
(match_operand:SWI48 3 "nonimmediate_operand")))
(clobber (reg:CC FLAGS_REG))]
"TARGET_BMI"
[(parallel
[(set (match_dup 4) (and:SWI48 (not:SWI48 (match_dup 2)) (match_dup 1)))
(clobber (reg:CC FLAGS_REG))])
(parallel
[(set (match_dup 0) (xor:SWI48 (match_dup 4) (match_dup 3)))
(clobber (reg:CC FLAGS_REG))])]
"operands[4] = gen_reg_rtx (<MODE>mode);")
;; Variant 3 of 4: Split ((A | B) ^ C) ^ A as (B & ~A) ^ C.
(define_split
[(set (match_operand:SWI48 0 "register_operand")
(xor:SWI48
(xor:SWI48
(ior:SWI48 (match_operand:SWI48 1 "register_operand")
(match_operand:SWI48 2 "nonimmediate_operand"))
(match_operand:SWI48 3 "nonimmediate_operand"))
(match_dup 1)))
(clobber (reg:CC FLAGS_REG))]
"TARGET_BMI"
[(parallel
[(set (match_dup 4) (and:SWI48 (not:SWI48 (match_dup 1)) (match_dup 2)))
(clobber (reg:CC FLAGS_REG))])
(parallel
[(set (match_dup 0) (xor:SWI48 (match_dup 4) (match_dup 3)))
(clobber (reg:CC FLAGS_REG))])]
"operands[4] = gen_reg_rtx (<MODE>mode);")
;; Variant 4 of 4: Split ((A | B) ^ C) ^ B as (A & ~B) ^ C.
(define_split
[(set (match_operand:SWI48 0 "register_operand")
(xor:SWI48
(xor:SWI48
(ior:SWI48 (match_operand:SWI48 1 "register_operand")
(match_operand:SWI48 2 "register_operand"))
(match_operand:SWI48 3 "nonimmediate_operand"))
(match_dup 2)))
(clobber (reg:CC FLAGS_REG))]
"TARGET_BMI"
[(parallel
[(set (match_dup 4) (and:SWI48 (not:SWI48 (match_dup 2)) (match_dup 1)))
(clobber (reg:CC FLAGS_REG))])
(parallel
[(set (match_dup 0) (xor:SWI48 (match_dup 4) (match_dup 3)))
(clobber (reg:CC FLAGS_REG))])]
"operands[4] = gen_reg_rtx (<MODE>mode);")
;; Logical inclusive and exclusive OR instructions

9
gcc/testsuite/gcc.target/i386/bmi-andn-4.c Normal file
View file

@ -0,0 +1,9 @@
/* { dg-do compile } */
/* { dg-options "-O2 -mbmi" } */
int f(int a, int b, int c)
{
return (a ^ b) ^ (a | c);
}
/* { dg-final { scan-assembler "andn\[ \\t\]+" } } */