procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

aarch64: Fix __builtin_apply with -mgeneral-regs-only [PR113486]

Browse source 
The problem here is the builtin apply mechanism thinks the FP registers
are to be used due to get_raw_arg_mode not returning VOIDmode. This
fixes that oversight and the backend now returns VOIDmode for non-general-regs
if TARGET_GENERAL_REGS_ONLY is true.

Built and tested for aarch64-linux-gnu with no regressions.

	PR target/113486

gcc/ChangeLog:

	* config/aarch64/aarch64.cc (aarch64_get_reg_raw_mode): For
	TARGET_GENERAL_REGS_ONLY, return VOIDmode for non-GP_REGNUM_P regno.

gcc/testsuite/ChangeLog:

	* gcc.target/aarch64/builtin_apply-1.c: New test.

Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
This commit is contained in:
Andrew Pinski 2024-01-18 10:40:04 -08:00
parent fb54b97728
commit d3ff08a376
2 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gcc/config/aarch64/aarch64.cc
View file

@ -7221,6 +7221,10 @@ aarch64_function_arg_boundary (machine_mode mode, const_tree type)
static fixed_size_mode
aarch64_get_reg_raw_mode (int regno)
{
/* Don't use any non GP registers for __builtin_apply and
__builtin_return if general registers only mode is requested. */
if (TARGET_GENERAL_REGS_ONLY && !GP_REGNUM_P (regno))
return as_a <fixed_size_mode> (VOIDmode);
if (TARGET_SVE && FP_REGNUM_P (regno))
/* Don't use the SVE part of the register for __builtin_apply and
__builtin_return. The SVE registers aren't used by the normal PCS,

12
gcc/testsuite/gcc.target/aarch64/builtin_apply-1.c Normal file
View file

@ -0,0 +1,12 @@
/* { dg-do compile } */
/* { dg-options "-mgeneral-regs-only" } */
/* PR target/113486 */
/* __builtin_apply should not use FP registers if
general registers only mode is requested. */
void
foo (void)
{
__builtin_apply (foo, 0, 0);
}