procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

cobol: Fix up COBOL -include [PR119777]

Browse source 
I was looking through options.cc diff between GCC 14 and 15, looking for
entries with added CL_Cobol where at least one other language is present
and was present before too.  Besides the -fsyntax-only changes this is
the only other one I found, COBOL adds Var(cobol_include) to something
which didn't have a Var at all before and IMHO it is actively harmful.
Because one can specify multiple -include file1 -include file2 options,
both in C/C++ etc. and in COBOL as well (as documented in the man
page).  A Var can track just one entry.  cobol_langhook_handle_option
should use arg instead.

2025-04-14  Jakub Jelinek  <jakub@redhat.com>

	PR cobol/119777
	* lang.opt (include): Remove Var(cobol_include).
	* cobol1.cc (cobol_langhook_handle_option) <case OPT_include>: Use
	arg instead of cobol_include.
This commit is contained in:
Jakub Jelinek 2025-04-14 19:32:43 +02:00 • committed by Jakub Jelinek
parent e96cb35ceb
commit d0b41f3d6d
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gcc/cobol/cobol1.cc
View file

@ -413,8 +413,8 @@ cobol_langhook_handle_option (size_t scode,
}
return true;
case OPT_include:
if( ! include_file_add(cobol_include) ) {
cbl_errx( "could not include %s", cobol_include);
if( ! include_file_add(arg) ) {
cbl_errx( "could not include %s", arg);
}
return true;

2
gcc/cobol/lang.opt
View file

@ -114,7 +114,7 @@ Cobol Joined Separate
; Documented in C
include
Cobol Joined Separate Var(cobol_include)
Cobol Joined Separate
; Documented in C
isysroot