c++: Seed namespaces for bindings [PR106363]

Currently the first depset for an EK_BINDING is not seeded. This breaks
the attached testcase as then the namespace is not considered referenced
yet during streaming, but we've already finished importing.

There doesn't seem to be any particular reason I could find for skipping
the first depset for bindings, and removing the condition doesn't appear
to cause any test failures, so this patch removes that check.

	PR c++/106363

gcc/cp/ChangeLog:

	* module.cc (module_state::write_cluster): Don't skip first
	depset for bindings.

gcc/testsuite/ChangeLog:

	* g++.dg/modules/pr106363_a.C: New test.
	* g++.dg/modules/pr106363_b.C: New test.

Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>
This commit is contained in:
Nathaniel Shead 2023-11-12 11:54:43 +11:00
parent 7abc7aae56
commit cb76f46c97
3 changed files with 20 additions and 3 deletions

View file

@ -14761,9 +14761,7 @@ module_state::write_cluster (elf_out *to, depset *scc[], unsigned size,
for (unsigned ix = 0; ix != size; ix++)
{
depset *b = scc[ix];
for (unsigned jx = (b->get_entity_kind () == depset::EK_BINDING
|| b->is_special ()) ? 1 : 0;
jx != b->deps.length (); jx++)
for (unsigned jx = b->is_special (); jx != b->deps.length (); jx++)
{
depset *dep = b->deps[jx];

View file

@ -0,0 +1,9 @@
// PR c++/106363
// { dg-additional-options "-fmodules-ts" }
// { dg-module-cmi pr106363.a }
export module pr106363.a;
namespace ns {
export int x;
}

View file

@ -0,0 +1,10 @@
// PR c++/106363
// { dg-additional-options "-fmodules-ts" }
// { dg-module-cmi pr106363.b }
export module pr106363.b;
import pr106363.a;
namespace ns {
export using ns::x;
}