procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

re PR c/30265 (Compound literal can cause invalid gimple)

Browse source 
2007-04-21  Andrew Pinski  <andrew_pinski@playstation.sony.com>

        PR C/30265
        * c-gimplifier.c (gimplify_compound_literal_expr): Mark the
        decl as addressable if the compound literal was marked as
        addressable.
        Mark the decl as a gimple register if it is a complex or
        vector decl and does not live in memory.
2007-04-21  Andrew Pinski  <andrew_pinski@playstation.sony.com>

        PR C/30265
        * gcc.c-torture/compile/compound-literal-2.c: New testcase.
        * gcc.c-torture/compile/compound-literal-3.c: New testcase.

From-SVN: r124024
This commit is contained in:
Andrew Pinski 2007-04-21 21:47:35 +00:00 • committed by Andrew Pinski
parent c284e49989
commit c8a0a219fd
5 changed files with 45 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
gcc/ChangeLog
View file

@ -1,3 +1,12 @@
2007-04-21 Andrew Pinski <andrew_pinski@playstation.sony.com>
PR C/30265
* c-gimplifier.c (gimplify_compound_literal_expr): Mark the
decl as addressable if the compound literal was marked as
addressable.
Mark the decl as a gimple register if it is a complex or
vector decl and does not live in memory.
2007-04-21 Andrew Pinski <andrew_pinski@playstation.sony.com>
* tree.h (GIMPLE_TUPLE_P): Also true for PHI_NODEs.

14
gcc/c-gimplify.c
View file

@ -183,6 +183,20 @@ gimplify_compound_literal_expr (tree *expr_p, tree *pre_p)
{
tree decl_s = COMPOUND_LITERAL_EXPR_DECL_STMT (*expr_p);
tree decl = DECL_EXPR_DECL (decl_s);
/* Mark the decl as addressable if the compound literal
expression is addressable now, otherwise it is marked too late
after we gimplify the initialization expression. */
if (TREE_ADDRESSABLE (*expr_p))
TREE_ADDRESSABLE (decl) = 1;
/* Preliminarily mark non-addressed complex variables as eligible
for promotion to gimple registers. We'll transform their uses
as we find them. */
if ((TREE_CODE (TREE_TYPE (decl)) == COMPLEX_TYPE
|| TREE_CODE (TREE_TYPE (decl)) == VECTOR_TYPE)
&& !TREE_THIS_VOLATILE (decl)
&& !needs_to_live_in_memory (decl))
DECL_GIMPLE_REG_P (decl) = 1;
/* This decl isn't mentioned in the enclosing block, so add it to the
list of temps. FIXME it seems a bit of a kludge to say that

6
gcc/testsuite/ChangeLog
View file

@ -1,3 +1,9 @@
2007-04-21 Andrew Pinski <andrew_pinski@playstation.sony.com>
PR C/30265
* gcc.c-torture/compile/compound-literal-2.c: New testcase.
* gcc.c-torture/compile/compound-literal-3.c: New testcase.
2007-04-21 Richard Guenther <rguenther@suse.de>
PR middle-end/31136

8
gcc/testsuite/gcc.c-torture/compile/compound-literal-2.c Normal file
View file

@ -0,0 +1,8 @@
/* PR C/30265, invalid gimple was produced because we did not mark
the compound literal's decl early enough. */
int f(float *);
int g(float x)
{
return f(&(float){x}) + f(&x);
}

8
gcc/testsuite/gcc.c-torture/compile/compound-literal-3.c Normal file
View file

@ -0,0 +1,8 @@
/* PR C/30265, invalid gimple was produced because we did not mark
the compound literal's decl early enough. */
int f(_Complex float *);
int g(_Complex float x)
{
return f(&(_Complex float){x+1}) + f(&x);
}