procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

aarch64: Fix out-of-bounds ENCODED_ELT access [PR113572]

Browse source 
When generalising vector_cst_all_same, I'd forgotten to update
VECTOR_CST_ENCODED_ELT to VECTOR_CST_ELT.  The check deliberately
looks at implicitly encoded elements in some cases.

gcc/
	PR target/113572
	* config/aarch64/aarch64-sve-builtins.cc (vector_cst_all_same):
	Check VECTOR_CST_ELT instead of VECTOR_CST_ENCODED_ELT

gcc/testsuite/
	PR target/113572
	* gcc.target/aarch64/sve/pr113572.c: New test.
This commit is contained in:
Richard Sandiford 2024-01-25 12:03:18 +00:00
parent 8eead1148c
commit c3de14ba1b
2 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gcc/config/aarch64/aarch64-sve-builtins.cc
View file

@ -3474,7 +3474,7 @@ vector_cst_all_same (tree v, unsigned int step)
unsigned int nelts = lcm * VECTOR_CST_NELTS_PER_PATTERN (v);
tree first_el = VECTOR_CST_ENCODED_ELT (v, 0);
for (unsigned int i = 0; i < nelts; i += step)
if (!operand_equal_p (VECTOR_CST_ENCODED_ELT (v, i), first_el, 0))
if (!operand_equal_p (VECTOR_CST_ELT (v, i), first_el, 0))
return false;
return true;

12
gcc/testsuite/gcc.target/aarch64/sve/pr113572.c Normal file
View file

@ -0,0 +1,12 @@
#include <arm_sve.h>
uint64_t u;
struct S { int i; } he;
void
foo ()
{
svuint64_t vld_clz = svld1_u64 (svwhilelt_b64 (0, 4), (uint64_t *) &he);
vld_clz = svclz_u64_z (svwhilelt_b64 (0, 1), vld_clz);
svst1_u64 (svwhilelt_b64 (0, 1), &u, vld_clz);
}