procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

i386: Fix FAIL of gcc.target/i386/pr78794.c on ia32.

Browse source 
This patch fixes that FAIL of gcc.target/i386/pr78794.c on ia32, which
is caused by minor STV rtx_cost differences with -march=silvermont.
It turns out that generic tuning results in pandn, but the lack of
accurate parameterization for COMPARE in compute_convert_gain combined
with small differences in scalar<->SSE costs on silvermont results in
this DImode chain not being converted.

The solution is to provide more accurate costs/gains for converting
(DImode and SImode) comparisons.

I'd been holding off of doing this as I'd thought it would be possible
to turn pandn;ptestz into ptestc (for an even bigger scalar-to-vector
win) but I've recently realized that these optimizations (as I've
implemented them) occur in the wrong order (stv2 occurs after
combine), so it isn't easy for STV to convert CCZmode into CCCmode.
Doh!  Perhaps something can be done in peephole2.

2023-06-28  Roger Sayle  <roger@nextmovesoftware.com>

gcc/ChangeLog
	PR target/78794
	* config/i386/i386-features.cc (compute_convert_gain): Provide
	more accurate gains for conversion of scalar comparisons to
	PTEST.
This commit is contained in:
Roger Sayle 2023-06-28 11:07:47 +01:00
parent 45c53768b6
commit c027592d39
1 changed files with 25 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
gcc/config/i386/i386-features.cc
View file

@ -631,7 +631,31 @@ general_scalar_chain::compute_convert_gain ()
break;
case COMPARE:
/* Assume comparison cost is the same. */
if (XEXP (src, 1) != const0_rtx)
{
/* cmp vs. pxor;pshufd;ptest. */
igain += COSTS_N_INSNS (m - 3);
}
else if (GET_CODE (XEXP (src, 0)) != AND)
{
/* test vs. pshufd;ptest. */
igain += COSTS_N_INSNS (m - 2);
}
else if (GET_CODE (XEXP (XEXP (src, 0), 0)) != NOT)
{
/* and;test vs. pshufd;ptest. */
igain += COSTS_N_INSNS (2 * m - 2);
}
else if (TARGET_BMI)
{
/* andn;test vs. pandn;pshufd;ptest. */
igain += COSTS_N_INSNS (2 * m - 3);
}
else
{
/* not;and;test vs. pandn;pshufd;ptest. */
igain += COSTS_N_INSNS (3 * m - 3);
}
break;
case CONST_INT: