libstdc++: Tell GCC what basic_string::_M_is_local() means [PR109299]
This avoids a bogus warning about overflowing a buffer, because GCC can't tell that we don't copy into the buffer unless it fits. By adding a __builtin_unreachable() hint we inform the compiler about the invariant that the buffer is only used when it's big enough. This can also improve codegen, by eliminating dead code that GCC couldn't tell was unreachable. libstdc++-v3/ChangeLog: PR libstdc++/109299 * include/bits/basic_string.h (basic_string::_M_is_local()): Add hint for compiler that local strings fit in the local buffer.
This commit is contained in:
parent
cf19ef9eca
commit
bf78b43873
1 changed files with 9 additions and 1 deletions
|
@ -271,7 +271,15 @@ _GLIBCXX_BEGIN_NAMESPACE_CXX11
|
|||
_GLIBCXX20_CONSTEXPR
|
||||
bool
|
||||
_M_is_local() const
|
||||
{ return _M_data() == _M_local_data(); }
|
||||
{
|
||||
if (_M_data() == _M_local_data())
|
||||
{
|
||||
if (_M_string_length > _S_local_capacity)
|
||||
__builtin_unreachable();
|
||||
return true;
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
||||
// Create & Destroy
|
||||
_GLIBCXX20_CONSTEXPR
|
||||
|
|
Loading…
Add table
Reference in a new issue