procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

PR c++/83820 - excessive attribute arguments not detected.

Browse source 
* parser.c (cp_parser_std_attribute): Detect excessive arguments.

	* g++.dg/cpp0x/gen-attrs-67.C: New test.

From-SVN: r272395
This commit is contained in:
Marek Polacek 2019-06-17 18:26:07 +00:00 • committed by Marek Polacek
parent 39f901e918
commit bf0af866a4
4 changed files with 35 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gcc/cp/ChangeLog
View file

@ -1,3 +1,8 @@
2019-06-17 Marek Polacek <polacek@redhat.com>
PR c++/83820 - excessive attribute arguments not detected.
* parser.c (cp_parser_std_attribute): Detect excessive arguments.
2019-06-17 Nathan Sidwell <nathan@acm.org>
PR c++/90754

14
gcc/cp/parser.c
View file

@ -26149,6 +26149,20 @@ cp_parser_std_attribute (cp_parser *parser, tree attr_ns)
vec<tree, va_gc> *vec;
int attr_flag = normal_attr;
/* Maybe we don't expect to see any arguments for this attribute. */
const attribute_spec *as
= lookup_attribute_spec (TREE_PURPOSE (attribute));
if (as && as->max_length == 0)
{
error_at (token->location, "%qE attribute does not take any arguments",
attr_id);
cp_parser_skip_to_closing_parenthesis (parser,
/*recovering=*/true,
/*or_comma=*/false,
/*consume_paren=*/true);
return error_mark_node;
}
if (attr_ns == gnu_identifier
&& attribute_takes_identifier_p (attr_id))
/* A GNU attribute that takes an identifier in parameter. */

5
gcc/testsuite/ChangeLog
View file

@ -1,3 +1,8 @@
2019-06-17 Marek Polacek <polacek@redhat.com>
PR c++/83820 - excessive attribute arguments not detected.
* g++.dg/cpp0x/gen-attrs-67.C: New test.
2019-06-17 Nathan Sidwell <nathan@acm.org>
PR c++/90754

11
gcc/testsuite/g++.dg/cpp0x/gen-attrs-67.C Normal file
View file

@ -0,0 +1,11 @@
// PR c++/83820 - excessive attribute arguments not detected.
// { dg-do compile { target c++11 } }
[[noreturn()]] void f0 (); // { dg-error ".noreturn. attribute does not take any arguments" }
[[noreturn(1)]] void f1 (); // { dg-error ".noreturn. attribute does not take any arguments" }
[[noreturn(1, 2)]] void f2 (); // { dg-error ".noreturn. attribute does not take any arguments" }
[[maybe_unused()]] int f3(); // { dg-error ".maybe_unused. attribute does not take any arguments" }
[[nodiscard()]] int f4(); // { dg-error ".nodiscard. attribute does not take any arguments" }
[[gnu::noinline()]] int f5(); // { dg-error ".noinline. attribute does not take any arguments" }
[[gnu::constructor]] int f6();
[[gnu::constructor(101)]] int f7();