procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

driver: fix crash with --diagnostics-plain-output [PR117942]

Browse source 
We are crashing here because decode_cmdline_options_to_array has:

  if (!strcmp (opt, "-fdiagnostics-plain-output"))
    ...

but that doesn't handle the '--FLAG' variant.

	PR driver/117942

gcc/ChangeLog:

	* opts-common.cc (decode_cmdline_options_to_array): Also detect
	--diagnostics-plain-output.

Reviewed-by: Joseph Myers <josmyers@redhat.com>
This commit is contained in:
Marek Polacek 2024-12-09 08:19:35 -05:00
parent d4525729b7
commit be2062be9a
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gcc/opts-common.cc
View file

@ -1077,7 +1077,9 @@ decode_cmdline_options_to_array (unsigned int argc, const char **argv,
/* Expand -fdiagnostics-plain-output to its constituents. This needs
to happen here so that prune_options can handle -fdiagnostics-color
specially. */
if (!strcmp (opt, "-fdiagnostics-plain-output"))
if (opt[0] == '-'
&& (opt[1] == '-' || opt[1] == 'f')
&& !strcmp (opt + 2, "diagnostics-plain-output"))
{
/* If you have changed the default diagnostics output, and this new
output is not appropriately "plain" (e.g., the change needs to be