From b7008552b493edaca6af041a18ff436c37f259bc Mon Sep 17 00:00:00 2001 From: Rainer Orth Date: Tue, 11 Feb 2025 09:41:18 +0100 Subject: [PATCH] libphobos: Disable libphobos.phobos/std/concurrency.d on macOS 13+ [PR111628] The libphobos.phobos_shared/std/concurrency.d test just hangs on macOS 13 and beyond and isn't even termintated after the testsuite timeout is exceeded. Thus, more and more concurrency.exe processes keep accumulating, consuming CPU time for nothing. To avoid this, this patch skips the test on macOS 13+. The static test SEGVs immediately instead, but I'm skipping it too for symmetry. Tested on macOS 15 (where it becomes UNSUPPORTED) and 12 (where it still PASSes). I have no idea what happens on Darwin/arm64, so currently the skipping is restricted to Darwin/x86_64. 2025-02-10 Rainer Orth PR d/111628 * testsuite/libphobos.phobos/phobos.exp (libphobos_skip_tests): Add libphobos.phobos/std/concurrency.d on macOS 13+. * testsuite/libphobos.phobos_shared/phobos_shared.exp (libphobos_skip_tests): Likewise for libphobos.phobos_shared/std/concurrency.d --- libphobos/testsuite/libphobos.phobos/phobos.exp | 2 ++ libphobos/testsuite/libphobos.phobos_shared/phobos_shared.exp | 2 ++ 2 files changed, 4 insertions(+) diff --git a/libphobos/testsuite/libphobos.phobos/phobos.exp b/libphobos/testsuite/libphobos.phobos/phobos.exp index 55622698f13..3e74078f136 100644 --- a/libphobos/testsuite/libphobos.phobos/phobos.exp +++ b/libphobos/testsuite/libphobos.phobos/phobos.exp @@ -37,6 +37,8 @@ set libphobos_skip_tests { # Skip curl tests if library is not available { libphobos.phobos/etc/c/curl.d { ! libcurl_available } } { libphobos.phobos/std/net/curl.d { ! libcurl_available } } + # Skip concurrency.d test: SEGVs or hangs on macOS 13+ (PR d/111628). + { libphobos.phobos/std/concurrency.d { x86_64-apple-darwin2[2-9]* } } } # Initialize dg. diff --git a/libphobos/testsuite/libphobos.phobos_shared/phobos_shared.exp b/libphobos/testsuite/libphobos.phobos_shared/phobos_shared.exp index 2940a663a80..54acea78a68 100644 --- a/libphobos/testsuite/libphobos.phobos_shared/phobos_shared.exp +++ b/libphobos/testsuite/libphobos.phobos_shared/phobos_shared.exp @@ -37,6 +37,8 @@ set libphobos_skip_tests { # Skip curl tests if library is not available { libphobos.phobos_shared/etc/c/curl.d { ! libcurl_available } } { libphobos.phobos_shared/std/net/curl.d { ! libcurl_available } } + # Skip concurrency.d test: SEGVs or hangs on macOS 13+ (PR d/111628). + { libphobos.phobos_shared/std/concurrency.d { x86_64-apple-darwin2[2-9]* } } } # Initialize dg.